tests: add exnternal-prometheus integration test#5720
Merged
Pothulapati merged 8 commits intomainfrom Feb 16, 2021
Merged
Conversation
Fixes #5659 Though most control-plane components dont differntiate on default vs external prometheus, There have been issues w.r.t CLI and external prometheus i.e check, etc. This PR adds a e2e deep integration tests w.r.t external pronmetheus thereby running viz and non-viz cmds integration tests on a linkerd-viz ewith external prometheus instance Signed-off-by: Tarun Pothulapati <tarunpothulapati@outlook.com>
Contributor
Author
|
Depends on #5680 |
Signed-off-by: Tarun Pothulapati <tarunpothulapati@outlook.com>
Some tests had to be updated as they expect `linkerd-prometheus` to be present which isnt the case in this test. This was solved by having `external-prometheus` specific test golden files and used in this case. Signed-off-by: Tarun Pothulapati <tarunpothulapati@outlook.com>
Signed-off-by: Tarun Pothulapati <tarunpothulapati@outlook.com>
alpeb
reviewed
Feb 15, 2021
Member
alpeb
left a comment
alpeb
left a comment
There was a problem hiding this comment.
In stat_test.go, why leaving the extensive scenarios only for the case when using linkerd-prometheus? WDYT about parametrizing a bit those tests to repeat them for the external prometheus scenario?
Signed-off-by: Tarun Pothulapati <tarunpothulapati@outlook.com>
Signed-off-by: Tarun Pothulapati <tarunpothulapati@outlook.com>
Signed-off-by: Tarun Pothulapati <tarunpothulapati@outlook.com>
Contributor
Author
|
@alpeb Updated |
kleimkuhler
approved these changes
Feb 16, 2021
| } | ||
|
|
||
| TestHelper = testutil.NewGenericTestHelper(*linkerd, "", "l5d", "linkerd-viz", "", "", "", "", "", "", "", "", false, false, false, false, false, *http.DefaultClient, testutil.KubernetesHelper{}) | ||
| TestHelper = testutil.NewGenericTestHelper(*linkerd, "", "l5d", "linkerd-viz", "", "", "", "", "", "", "", "", false, false, false, false, false, false, *http.DefaultClient, testutil.KubernetesHelper{}) |
Contributor
There was a problem hiding this comment.
May be nice to make this a builder, or the fields public at some point. This function has a wild number of arguments!
jijeesh
pushed a commit
to jijeesh/linkerd2
that referenced
this pull request
Mar 23, 2021
* tests: add exnternal-prometheus integration test Fixes linkerd#5659 Though most control-plane components dont differntiate on default vs external prometheus, There have been issues w.r.t CLI and external prometheus i.e check, etc. This PR adds a e2e deep integration tests w.r.t external pronmetheus thereby running viz and non-viz cmds integration tests on a linkerd-viz ewith external prometheus instance Signed-off-by: Tarun Pothulapati <tarunpothulapati@outlook.com> Signed-off-by: Jijeesh <jijeesh.ka@gmail.com>
jijeesh
pushed a commit
to jijeesh/linkerd2
that referenced
this pull request
Apr 21, 2021
* tests: add exnternal-prometheus integration test Fixes linkerd#5659 Though most control-plane components dont differntiate on default vs external prometheus, There have been issues w.r.t CLI and external prometheus i.e check, etc. This PR adds a e2e deep integration tests w.r.t external pronmetheus thereby running viz and non-viz cmds integration tests on a linkerd-viz ewith external prometheus instance Signed-off-by: Tarun Pothulapati <tarunpothulapati@outlook.com> Signed-off-by: Jijeesh <jijeesh.ka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5659
Though most control-plane components dont differntiate on default
vs external prometheus, There have been issues w.r.t CLI and external
prometheus i.e check, etc.
This PR adds a e2e deep integration tests w.r.t external pronmetheus
thereby running viz and non-viz cmds integration tests on a linkerd-viz
ewith external prometheus instance
Signed-off-by: Tarun Pothulapati tarunpothulapati@outlook.com