cli: reorganise diagnostics subcommand#5205
Merged
Pothulapati merged 12 commits intomainfrom Feb 25, 2021
Merged
Conversation
Fixes #5192 This PR moves `metrics`, `diagnostics`(which prints out metrics of control-plane components) and `endpoints` into a new `diagnostics` subcommand. Signed-off-by: Tarun Pothulapati <tarunpothulapati@outlook.com>
Signed-off-by: Tarun Pothulapati <tarunpothulapati@outlook.com>
Signed-off-by: Tarun Pothulapati <tarunpothulapati@outlook.com>
kleimkuhler
reviewed
Nov 10, 2020
better descriotion Co-authored-by: Kevin Leimkuhler <kevin@kleimkuhler.com>
Signed-off-by: Tarun Pothulapati <tarunpothulapati@outlook.com>
Signed-off-by: Tarun Pothulapati <tarunpothulapati@outlook.com>
Signed-off-by: Tarun Pothulapati <tarunpothulapati@outlook.com>
Signed-off-by: Tarun Pothulapati <tarunpothulapati@outlook.com>
Signed-off-by: Tarun Pothulapati <tarunpothulapati@outlook.com>
Pothulapati
commented
Feb 23, 2021
| diagnosticsCmd.AddCommand(newCmdControllerMetrics()) | ||
| diagnosticsCmd.AddCommand(newCmdEndpoints()) | ||
| diagnosticsCmd.AddCommand(newCmdMetrics()) | ||
| diagnosticsCmd.AddCommand(newCmdInstallSP()) |
Contributor
Author
There was a problem hiding this comment.
Should we call the install-sp something else? As its a bit confusing as this installs service profiles for the control-plane components and not the service profiles crds itself
Member
There was a problem hiding this comment.
I don't have a better suggestion for the name of this.
Signed-off-by: Tarun Pothulapati <tarunpothulapati@outlook.com>
adleong
reviewed
Feb 23, 2021
| diagnosticsCmd.AddCommand(newCmdControllerMetrics()) | ||
| diagnosticsCmd.AddCommand(newCmdEndpoints()) | ||
| diagnosticsCmd.AddCommand(newCmdMetrics()) | ||
| diagnosticsCmd.AddCommand(newCmdInstallSP()) |
Member
There was a problem hiding this comment.
I don't have a better suggestion for the name of this.
cli/cmd/diagnostics.go
Outdated
|
|
||
| This command provides subcommands to diagnose the functionality of Linkerd.`, | ||
| Example: ` # Get control-plane component metrics | ||
| linkerd diagnostics cp-metrics |
Member
There was a problem hiding this comment.
cp-metrics doesn't seem like it's a valid abbreviation for this command.
Signed-off-by: Tarun Pothulapati <tarunpothulapati@outlook.com>
adleong
approved these changes
Feb 24, 2021
kleimkuhler
approved these changes
Feb 25, 2021
Contributor
kleimkuhler
left a comment
kleimkuhler
left a comment
There was a problem hiding this comment.
This looks good. There are some doc updates you should change before merging, but changes make sense and work as expected.
Signed-off-by: Tarun Pothulapati <tarunpothulapati@outlook.com>
jijeesh
pushed a commit
to jijeesh/linkerd2
that referenced
this pull request
Mar 23, 2021
* cli: reorganise diagnostics subcommand Fixes linkerd#5192, linkerd#5193 This PR moves `metrics`, `diagnostics`(which prints out metrics of control-plane components), `endpoints` and `install-sp` into a new `diagnostics` subcommand. Signed-off-by: Tarun Pothulapati <tarunpothulapati@outlook.com> Signed-off-by: Jijeesh <jijeesh.ka@gmail.com>
jijeesh
pushed a commit
to jijeesh/linkerd2
that referenced
this pull request
Apr 21, 2021
* cli: reorganise diagnostics subcommand Fixes linkerd#5192, linkerd#5193 This PR moves `metrics`, `diagnostics`(which prints out metrics of control-plane components), `endpoints` and `install-sp` into a new `diagnostics` subcommand. Signed-off-by: Tarun Pothulapati <tarunpothulapati@outlook.com> Signed-off-by: Jijeesh <jijeesh.ka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5192, #5193
This PR moves
metrics,diagnostics(which prints out metrics ofcontrol-plane components),
endpointsandinstall-spinto a newdiagnosticssubcommand.
Signed-off-by: Tarun Pothulapati tarunpothulapati@outlook.com