Skip to content

Use buster for base and web images too#4567

Merged
cpretzer merged 1 commit intolinkerd:masterfrom
joakimr-axis:joakimr-axis_buster
Jun 15, 2020
Merged

Use buster for base and web images too#4567
cpretzer merged 1 commit intolinkerd:masterfrom
joakimr-axis:joakimr-axis_buster

Conversation

@joakimr-axis
Copy link
Contributor

@joakimr-axis joakimr-axis commented Jun 8, 2020

Requires setting iptables-legacy as the iptables provider.

Cred should go to @erikwilson and @codeman9 for suggesting the use of iptables-legacy.
k3s-io/k3s#116 (comment)
#3486 (comment)

Copy link
Contributor

@grampelberg grampelberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slick! Does this update the proxy-init image as well?

@olix0r
Copy link
Member

olix0r commented Jun 8, 2020

We still have linkerd/linkerd2-proxy-init#3 open -- it should be updated.

Requires setting iptables-legacy as the iptables provider.

Signed-off-by: Joakim Roubert <joakim.roubert@axis.com>
@cpretzer
Copy link
Contributor

cpretzer commented Jun 9, 2020

yep, I still have that in a branch. I think I need to use iptables-legacy for it as well

Awesome work @joakimr-axis

Copy link
Contributor

@cpretzer cpretzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@alpeb alpeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my testing, it appears the latest k8s versions are already ensuring the iptables command is linked against the legacy version without having to manually do it in our images, but it's good to have it anyways for older versions 👍

This is working fine using CNI. I'll test the non-CNI scenario in the linkerd2-proxy-init PR 😉

btw, I ran bin/docker-build-base and published the resulting gcr.io/linkerd-io/base:2020-06-08.01 image :shipit:

@cpretzer cpretzer merged commit 57f321b into linkerd:master Jun 15, 2020
@joakimr-axis joakimr-axis deleted the joakimr-axis_buster branch June 16, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants