Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group checkers by category #2080

Closed
wants to merge 2 commits into from
Closed

Group checkers by category #2080

wants to merge 2 commits into from

Commits on Jan 14, 2019

  1. Group checkers by category 

    The `linkerd check` command organized the various checks via loosely
coupled category IDs, category names, and checkers themselves, all with
ordering defined by consumers of this code.

This change removes category IDs in favor of category names, groups all
checkers by category, and enforces ordering at the `HealthChecker`
level.

Part of #1471, depends on #2078.

Signed-off-by: Andrew Seigner <[email protected]>
    @siggy
    siggy committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    07537c7 View commit details
    Browse the repository at this point in the history

  2. rename Checks -> CategoryID 

    Signed-off-by: Andrew Seigner <[email protected]>
    @siggy
    siggy committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    a02371a View commit details
    Browse the repository at this point in the history