Remove proxy bind timeout from CLIs #2017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klingerf
reviewed
Dec 20, 2018
|
Now that linkerd/linkerd2-proxy#165 has merged, I think this is unblocked. |
klingerf
reviewed
Jan 24, 2019
Signed-off-by: Eliza Weisman <[email protected]>
hawkw
force-pushed
the
eliza/rm-bind-timeout
branch
from
c569f65
to
06d0f34
Compare
Signed-off-by: Eliza Weisman <[email protected]>
klingerf
approved these changes
Jan 24, 2019
hawkw
added a commit
that referenced
this pull request
Jan 24, 2019
This was referenced Jan 25, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch removes the
--proxy-bind-timeoutflag from thelinkerd injectandlinkerd installCLI commands, and theLINKERD2_PROXY_BIND_TIMEOUTenvironment variable from their output.This is in preparation for removing that timeout from the proxy (as
described in #2013).
I thought it was prudent to remove this from the CLIs before removing it
from the proxy, so we can't create a situation where the CLIs produce
output that results in broken proxy containers.
Signed-off-by: Eliza Weisman [email protected]