-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove proxy bind timeout from CLIs #2017
Conversation
Now that linkerd/linkerd2-proxy#165 has merged, I think this is unblocked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating. Looks like this branch doesn't pass CI when merged with the latest master. Mind rebasing against latest master and fixing the tests?
Signed-off-by: Eliza Weisman <[email protected]>
c569f65
to
06d0f34
Compare
Signed-off-by: Eliza Weisman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐️ Looks great, thanks for updating!
This branch removes the
--proxy-bind-timeout
flag from thelinkerd inject
andlinkerd install
CLI commands, and theLINKERD2_PROXY_BIND_TIMEOUT
environment variable from their output.This is in preparation for removing that timeout from the proxy (as
described in #2013).
I thought it was prudent to remove this from the CLIs before removing it
from the proxy, so we can't create a situation where the CLIs produce
output that results in broken proxy containers.
Signed-off-by: Eliza Weisman [email protected]