Move all healthcheck-related code to pkg/healthcheck #1492
Conversation
Signed-off-by: Kevin Lingerfelt <[email protected]>
Signed-off-by: Kevin Lingerfelt <[email protected]>
There was a problem hiding this comment.
LGTM! 👍 . I like that we no longer run the remaining checks if one of the checks fail. Do you think there is value in displaying the checks that did not run so that the user is aware of them just in case they need to debug? Is something like this already going to be addressed in the --pre and --post flight checks?
| if err != nil { | ||
| os.Exit(2) | ||
| } | ||
| configureAndRunChecks(options) |
There was a problem hiding this comment.
I know this isn't part of the change, but the use of the possessive pronoun "your" is a little jarring especially when compared to other command descriptions. We may want to revisit this in a new PR.
There was a problem hiding this comment.
Ahhh, yeah, this is great feedback. I partially rewrote the description for this command in #1495, and I'll address this suggestion there.
As far as printing the skipped check goes, I'm a bit on the fence. If the user fails a fatal check, then they must fix it before being able to successfully use the CLI. In that case, printing the checks that were skipped might distract from the failure that requires fixing.
test/testdata/check.golden
Outdated
| linkerd-api[kubernetes]: control plane can talk to Kubernetes..............[ok] | ||
| linkerd-api[prometheus]: control plane can talk to Prometheus..............[ok] | ||
| linkerd-version: can get the latest version................................[ok] |
There was a problem hiding this comment.
slight naming nit: can we use "can query for the latest version" or "can determine the latest version" instead? "can get" to me implies some downloading (I wasn't sure what it meant at first)
There was a problem hiding this comment.
Ah, yep, great call! I like "can determine the latest version" a lot -- will update.
Signed-off-by: Kevin Lingerfelt <[email protected]>
This branch is a substantial refactor to the way our health check code was setup:
pkg/healthcheck/healthcheck.gohealthcheck.checkersstruct instead of protobufMockKubeApistruct has been removed, since it was no longer usedKubernetesApiinterface has been removed, since it only had one implementation after removing the mockThis refactor is in support of #1470, #1471, #1473, #1477, and #1478.