-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): address hyper deprecations in policy controller #13493
Draft
cratelyn
wants to merge
2
commits into
main
Choose a base branch
from
kate/hyper-1.x-upgrade
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cratelyn
force-pushed
the
kate/hyper-1.x-upgrade
branch
from
December 18, 2024 02:24
33432fe
to
f68339e
Compare
this contains some small patches that we're interested in, before we address deprecations and upgrade to hyper 1.0. see #8733 for more information. Signed-off-by: katelyn martin <[email protected]>
cratelyn
force-pushed
the
kate/hyper-1.x-upgrade
branch
from
December 18, 2024 02:27
f68339e
to
f6468a9
Compare
NB: this branch is based upon #13492. see #8733 for more information about migrating to hyper 1.0. this enables the `backports` and `deprecated` feature flags in the hyper dependencies in this project, and addresses warnings. see <https://hyper.rs/guides/1/upgrading/> for more information about these feature flags. largely, the control plane is unaffected by this upgrade, besides the following changes: * one usage of a deprecated `hyper::body::aggregate` function is updated. * a `hyper::rt::Executor<E>` implementation, which spawns tasks onto the tokio runtime, is provided. once we upgrade to hyper 1.0, we can replace this with the executor provided in [`hyper-util`](https://docs.rs/hyper-util/latest/hyper_util/rt/tokio/struct.TokioExecutor.html#impl-Executor%3CFut%3E-for-TokioExecutor). * the `hyper::service::Service<hyper::Request<tonic::body::BoxBody>>` implementation for `GrpcHttp` now boxes its returned future, on account of `SendRequest` returning an anonymous `impl Future<Output = ...>`. * the `policy-test` additionally depends on the `runtime` feature of hyper. this is an artifact of an internal config structure shared by the legacy connection builder and the backported connection builder containing two keep-alive fields that were feature gated prior to 1.0. Signed-off-by: katelyn martin <[email protected]>
cratelyn
force-pushed
the
kate/hyper-1.x-upgrade
branch
from
December 18, 2024 02:33
f6468a9
to
36c17fb
Compare
cratelyn
changed the title
chore(deps): address hyper deprecations in policy controllers
chore(deps): address hyper deprecations in policy controller
Dec 18, 2024
there's some feature flags to fight before i open this up for review. 🎏 |
ci was failing for this reason:
i've landed hyperium/hyper#3816 upstream to conditionally compile these interfaces in the backported http/2 server connection builder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB: this branch is based upon #13492. see #8733 for more information about migrating to hyper 1.0.
this enables the
backports
anddeprecated
feature flags in the hyper dependencies in this project, and addresses warnings. see https://hyper.rs/guides/1/upgrading/ for more information about these feature flags.largely, the control plane is unaffected by this upgrade, besides the following changes:
one usage of a deprecated
hyper::body::aggregate
function is updated.a
hyper::rt::Executor<E>
implementation, which spawns tasks onto the tokio runtime, is provided. once we upgrade to hyper 1.0, we can replace this with the executor provided inhyper-util
.the
hyper::service::Service<hyper::Request<tonic::body::BoxBody>>
implementation forGrpcHttp
now boxes its returned future, on account ofSendRequest
returning an anonymousimpl Future<Output = ...>
.the
policy-test
additionally depends on theruntime
feature of hyper. this is an artifact of an internal config structure shared by the legacy connection builder and the backported connection builder containing two keep-alive fields that were feature gated prior to 1.0.