Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTPLocalRateLimitPolicy validator #13251

Merged
merged 3 commits into from
Nov 12, 2024
Merged

HTTPLocalRateLimitPolicy validator #13251

merged 3 commits into from
Nov 12, 2024

Conversation

alpeb
Copy link
Member

@alpeb alpeb commented Oct 31, 2024

Followup to #13231

@alpeb alpeb requested a review from a team as a code owner October 31, 2024 17:19
@alpeb alpeb force-pushed the alpeb/rate-limiting-validator branch from bce6139 to e8d5447 Compare November 1, 2024 09:57
cratelyn
cratelyn approved these changes Nov 1, 2024
View reviewed changes
Copy link

@cratelyn cratelyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a policy controller expert, but this looks like a reasonable change to me.

@olix0r olix0r self-assigned this Nov 1, 2024
@alpeb alpeb force-pushed the alpeb/rate-limiting-validator branch 2 times, most recently from 44236ed to 11f1ff5 Compare November 5, 2024 17:23
@alpeb alpeb force-pushed the alpeb/rate-limiting-validator branch from 11f1ff5 to 3c34d86 Compare November 5, 2024 20:19
@alpeb
Copy link
Member Author

alpeb commented Nov 7, 2024 •
edited
Loading

In 5baa048 I added a validation enforcing that Servers can have at most one RL associated to them.

@alpeb alpeb force-pushed the alpeb/rate-limiting-validator branch from 45efa13 to 5baa048 Compare November 7, 2024 22:52
@alpeb alpeb mentioned this pull request Nov 8, 2024
Merged
@alpeb alpeb force-pushed the alpeb/rate-limiting branch 3 times, most recently from ed36e3a to 2c9c25b Compare November 8, 2024 22:48
Base automatically changed from alpeb/rate-limiting to main November 9, 2024 00:24
@alpeb alpeb force-pushed the alpeb/rate-limiting-validator branch from 5baa048 to f8f409b Compare November 9, 2024 10:06
@alpeb
Copy link
Member Author

alpeb commented Nov 9, 2024

I ended up withdrawing the validation for one RL per server, given we're doing that now in the policy controller itself.

olix0r
olix0r approved these changes Nov 11, 2024
View reviewed changes
policy-controller/src/admission.rs Outdated Show resolved Hide resolved
@alpeb alpeb merged commit 41b3b32 into main Nov 12, 2024
43 checks passed
@alpeb alpeb deleted the alpeb/rate-limiting-validator branch November 12, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cratelyn cratelyn cratelyn approved these changes

@olix0r olix0r olix0r approved these changes

Assignees

@olix0r olix0r

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alpeb @olix0r @cratelyn