policy: limit globally affecting egress networks to a single namespace #13246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zahari Dichev <[email protected]>
zaharidichev
changed the title
adleong
approved these changes
Oct 30, 2024
| @@ -61,14 +61,20 @@ impl EgressNetwork { | |||
| // Attempts to find the best matching network for a certain discovery look-up. | |||
| // Logic is: | |||
| // 1. if there are Egress networks in the source_namespace, only these are considered | |||
| // 2. otherwise only networks from the global egress network namespace are considered | |||
| // 2. the target IP is matched against the networks of the EgressNetwork | |||
| // 2. the target IP is matched against the networks of the EgressNetwork | ||
| // 3. ambiguity is resolved as by comparing the networks using compare_matched_egress_network | ||
| pub(crate) fn resolve_egress_network<'n>( | ||
| addr: IpAddr, | ||
| source_namespace: String, | ||
| global_external_network_namespace: Arc<String>, |
There was a problem hiding this comment.
would it simplify things to just take a &str here since we don't actually need to take ownership of the String?
Signed-off-by: Zahari Dichev <[email protected]>
zaharidichev
added a commit
that referenced
this pull request
Nov 1, 2024
In a previous PR (#13246) we introduced an egress networks namespace that is used to create `EgressNetwork` objects that affect all client workloads. This change makes this namespace configurable through helm values. Additionally, we unify the naming convention of the arguments to use **egress** as opposed to **external** Signed-off-by: Zahari Dichev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces an
global_external_network_namespaceargument to the policy controller and alters the semantics ofEgressNetworkmatching in a way that:Signed-off-by: Zahari Dichev [email protected]