Allow configuring proxy trace export protocol #13099
Merged
+52
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpeb
reviewed
Sep 24, 2024
sfleen
force-pushed
the
otel
branch
2 times, most recently
from
dacf90e
to
b72509d
Compare
sfleen
force-pushed
the
otel
branch
2 times, most recently
from
e41e4f3
to
8c1d9d5
Compare
Allows setting the trace export protocol env var (`LINKERD2_PROXY_TRACE_PROTOCOL`) on instances of the proxy using the existing mechanisms we have today for setting the trace collector endpoint (helm values, annotations, etc.). Currently defaults the protocol to `opencensus` to match the behavior we have today. \linkerd#10111 Signed-off-by: Scott Fleener <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows setting the trace export protocol env var (
LINKERD2_PROXY_TRACE_PROTOCOL) on instances of the proxy using the existing mechanisms we have today for setting the trace collector endpoint (helm values, annotations, etc.).Currently defaults the protocol to
opencensusto match the behavior we have today.#10111