Add support to modify liveness and readiness probe timeouts on control plane containers in helm chart

[kristjankullerkann-wearemp]

This PR adds support for custom liveness and readiness probe timeouts on control plane containers in helm chart.

It was discussed on #12895 with @alpeb

[alpeb]

Thanks @kristjankullerkann-wearemp ! 👍
Just couple of comments below.
Also, please don't forget to run bin/helm-docs to re-generate the README chart files with the new values.yaml entries.

[kristjankullerkann-wearemp]

Thanks @kristjankullerkann-wearemp ! 👍 Just couple of comments below. Also, please don't forget to run bin/helm-docs to re-generate the README chart files with the new values.yaml entries.

I did run helm-docs but there wasn't any updates except helm-docs footer itself so I decided not to commit this.

[alpeb]

Looking good 👍
Given that those new settings will always be set, at least to their defaults, the tests golden files need to be updated. You can do that with go test ./... -update.

[kristjankullerkann-wearemp]

Looking good 👍 Given that those new settings will always be set, at least to their defaults, the tests golden files need to be updated. You can do that with go test ./... -update.

Files updated.

[alpeb]

Can you please address the DCO?

[kristjankullerkann-wearemp]

Can you please address the DCO?

Sorry, missed signoff for second commit. Should be there now.

[alpeb]

There still are missing changes to tests; please apply the following:

diff --git a/cli/cmd/install_test.go b/cli/cmd/install_test.go
index 7d06da27f..2f1e1bd02 100644
--- a/cli/cmd/install_test.go
+++ b/cli/cmd/install_test.go
@@ -60,6 +60,7 @@ func TestRender(t *testing.T) {
                CNIEnabled:              false,
                IdentityTrustDomain:     defaultValues.IdentityTrustDomain,
                IdentityTrustAnchorsPEM: defaultValues.IdentityTrustAnchorsPEM,
+               DestinationController:   map[string]any{},
                PodAnnotations:          map[string]string{},
                PodLabels:               map[string]string{},
                PriorityClassName:       "PriorityClassName",
diff --git a/pkg/charts/linkerd2/values_test.go b/pkg/charts/linkerd2/values_test.go
index ac239ea37..4ac0e8506 100644
--- a/pkg/charts/linkerd2/values_test.go
+++ b/pkg/charts/linkerd2/values_test.go
@@ -98,6 +98,12 @@ func TestNewValues(t *testing.T) {
                                        "while_idle": true,
                                },
                        },
+                       "livenessProbe":  map[string]interface{}{"timeoutSeconds": 1.0},
+                       "readinessProbe": map[string]interface{}{"timeoutSeconds": 1.0},
+               },
+               SPValidator: map[string]interface{}{
+                       "livenessProbe":  map[string]interface{}{"timeoutSeconds": 1.0},
+                       "readinessProbe": map[string]interface{}{"timeoutSeconds": 1.0},
                },
                PolicyController: &PolicyController{
                        Image: &Image{

and then run go test ./... -update one more time.

[kristjankullerkann-wearemp]

There still are missing changes to tests; please apply the following:

diff --git a/cli/cmd/install_test.go b/cli/cmd/install_test.go
index 7d06da27f..2f1e1bd02 100644
--- a/cli/cmd/install_test.go
+++ b/cli/cmd/install_test.go
@@ -60,6 +60,7 @@ func TestRender(t *testing.T) {
                CNIEnabled:              false,
                IdentityTrustDomain:     defaultValues.IdentityTrustDomain,
                IdentityTrustAnchorsPEM: defaultValues.IdentityTrustAnchorsPEM,
+               DestinationController:   map[string]any{},
                PodAnnotations:          map[string]string{},
                PodLabels:               map[string]string{},
                PriorityClassName:       "PriorityClassName",
diff --git a/pkg/charts/linkerd2/values_test.go b/pkg/charts/linkerd2/values_test.go
index ac239ea37..4ac0e8506 100644
--- a/pkg/charts/linkerd2/values_test.go
+++ b/pkg/charts/linkerd2/values_test.go
@@ -98,6 +98,12 @@ func TestNewValues(t *testing.T) {
                                        "while_idle": true,
                                },
                        },
+                       "livenessProbe":  map[string]interface{}{"timeoutSeconds": 1.0},
+                       "readinessProbe": map[string]interface{}{"timeoutSeconds": 1.0},
+               },
+               SPValidator: map[string]interface{}{
+                       "livenessProbe":  map[string]interface{}{"timeoutSeconds": 1.0},
+                       "readinessProbe": map[string]interface{}{"timeoutSeconds": 1.0},
                },
                PolicyController: &PolicyController{
                        Image: &Image{

and then run go test ./... -update one more time.

Done and thanks.

[alpeb]

Thanks @kristjankullerkann-wearemp ! This looks good to me 👍