feat: Configure default HTTP/2 server keep-alives #12498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTP/2 keep-alives enable HTTP/2 servers to issue PING messages to clients to ensure that the connections are still healthy. This is especially useful when the OS loses a FIN packet, which causes the connection resources to be held by the proxy until we attempt to write to the socket again. Keep-alives provide a mechanism to issue periodic writes on the socket to test the connection health. 5760ed2 updated the proxy to support HTTP/2 server configuration and 9e241a7 updated the proxy's Helm templating to support aribtrary configuration. Together, these changes enable configuring default HTTP/2 server keep-alives for all data planes in a cluster. The default keep-alive configuration uses a 10s interval and a 3s timeout. These are chosen to be conservative enough that they don't trigger false positive timeouts, but frequent enough that these connections may be garbage collected in a timely fashion.
olix0r
force-pushed
the
ver/server-keep-alive
branch
from
c645e34
to
9268bb2
Compare
alpeb
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP/2 keep-alives enable HTTP/2 servers to issue PING messages to clients to ensure that the connections are still healthy. This is especially useful when the OS loses a FIN packet, which causes the connection resources to be held by the proxy until we attempt to write to the socket again. Keep-alives provide a mechanism to issue periodic writes on the socket to test the connection health.
5760ed2 updated the proxy to support HTTP/2 server configuration and 9e241a7 updated the proxy's Helm templating to support aribtrary configuration. Together, these changes enable configuring default HTTP/2 server keep-alives for all data planes in a cluster.
The default keep-alive configuration uses a 10s interval and a 3s timeout. These are chosen to be conservative enough that they don't trigger false positive timeouts, but frequent enough that these connections may be garbage collected in a timely fashion.