Clean up go.mod require blocks
#12367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`go.mod` files should have exactly two require blocks, one for direct dependencies and one for indirect dependencies: https://go.dev/doc/modules/gomod-ref#go-notes Dependabot PR #8433 created a third `require` block in `go.mod`, possibly because the first `require` block was already a (non-standard) mix of direct and indirect dependencies: golang/go#51983 (comment) Modify `go.mod` to have two `require` blocks, one for direct deps, another for indirect. Signed-off-by: Andrew Seigner <[email protected]>
olix0r
approved these changes
Mar 28, 2024
the-wondersmith
pushed a commit
to the-wondersmith/linkerd2
that referenced
this pull request
Apr 24, 2024
`go.mod` files should have exactly two require blocks, one for direct dependencies and one for indirect dependencies: https://go.dev/doc/modules/gomod-ref#go-notes Dependabot PR linkerd#8433 created a third `require` block in `go.mod`, possibly because the first `require` block was already a (non-standard) mix of direct and indirect dependencies: golang/go#51983 (comment) Modify `go.mod` to have two `require` blocks, one for direct deps, another for indirect. Signed-off-by: Andrew Seigner <[email protected]> Signed-off-by: Mark S <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go.modfiles should have exactly two require blocks, one for direct dependencies and one for indirect dependencies:https://go.dev/doc/modules/gomod-ref#go-notes
Dependabot PR #8433 created a third
requireblock ingo.mod, possibly because the firstrequireblock was already a (non-standard) mix of direct and indirect dependencies:golang/go#51983 (comment)
Modify
go.modto have tworequireblocks, one for direct deps, another for indirect.