Add default values to proxy-*-connect-timeout annotations docs
#12155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finding these values in the docs site is pretty painful Update the documentation to follow other proxy fields in providing a default value at the end of the description for the field Fixes #12154 Signed-off-by: Akshay Dongaonkar <[email protected]>
alpeb
reviewed
Feb 29, 2024
alpeb
reviewed
Mar 7, 2024
alpeb
reviewed
Mar 7, 2024
alpeb
approved these changes
Mar 14, 2024
alpeb
changed the title
proxy-*-connect-timeout annotations docs
|
Hey @alpeb thanks for applying the suggestion and merging in the submission! I really appreciate it. Sorry I couldn't respond sooner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finding these values in the docs site is pretty painful
Update the documentation to follow other proxy fields in providing a default value at the end of the description for the field
Fixes #12154