-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add affinity settings in viz and jaeger chart #11464
Conversation
Signed-off-by: Naing Naing Htun <[email protected]>
e92995d
to
8436166
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @naing2victor!
I noticed that you're setting the component and label values which are used by podAntiAffinity, not nodeAffinity. What do you think of adding
# -- Enables Pod Anti Affinity logic to balance the placement of replicas
# across hosts and zones for High Availability.
# Enable this only when you have multiple replicas of components.
enablePodAntiAffinity: false
to the values.yaml since we're setting those component and label values anyway. That makes it consistent with the other extensions as well.
@adleong Thank you for your feedback. I can see that Would it be better if we separate the variable by the component. For example,
Or just using 1 value for all the components.
|
I'd recommend having a separate replicas value for each component (which is what we do in linkerd-viz). However, the exception to that is that increasing the number of replicas of the |
- variablize replica value for each component except `jager` component - add update strategy - update docs Signed-off-by: Naing Naing Htun <[email protected]>
I've added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you try rendering the templates with enablePodAntiAffinity=true
you'll see there's a problem. I believe the issue is not passing $tree
into the linkerd.affinity
include.
eef562d
to
e17f2a3
Compare
- issue is not passing `$tree` into the `linkerd.affinity` include - move `jaegerInjector` under `webhook` - Capitalize comments Signed-off-by: Naing Naing Htun <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
## edge-23.11.4 This edge release introduces support for the native sidecar containers entering beta support in Kubernetes 1.29. This improves the startup and shutdown ordering for the proxy relative to other containers, fixing the long-standing shutdown issue with injected `Job`s. Furthermore, traffic from other `initContainer`s can now be proxied by Linkerd. In addition, this edge release includes Helm chart improvements, and improvements to the multicluster extension. * Added a new `config.alpha.linkerd.io/proxy-enable-native-sidecar` annotation and `Proxy.NativeSidecar` Helm option that causes the proxy container to run as an init-container (thanks @teejaded!) (#11465; fixes #11461) * Fixed broken affinity rules for the multicluster `service-mirror` when running in HA mode (#11609; fixes #11603) * Added a new check to `linkerd check` that ensures all extension namespaces are configured properly (#11629; fixes #11509) * Updated the Prometheus Docker image used by the `linkerd-viz` extension to v2.48.0, resolving a number of CVEs in older Prometheus versions (#11633) * Added `nodeAffinity` to `deployment` templates in the `linkerd-viz` and `linkerd-jaeger` Helm charts (thanks @naing2victor!) (#11464; fixes #10680)
Add
nodeAffinity
fordeployment
template tolinkerd-viz
andlinkerd-jaeger
chartsFixes #10680