Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service mirror improvements #11223

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Conversation

adleong
Copy link
Member

@adleong adleong commented Aug 8, 2023

This is a follow-up to #11201, addressing some feedback from that PR.

  • fixes a typo in a comment
  • do not copy the topology aware hints (TAH) annotation onto mirror service, becuase TAH is not multicluster aware.

@adleong adleong requested a review from a team as a code owner August 8, 2023 19:58
Copy link
Member

@alpeb alpeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of k8s 1.27 this annotation is named service.kubernetes.io/topology-mode
https://kubernetes.io/docs/concepts/services-networking/topology-aware-routing/#enabling-topology-aware-routing
So I think we should filter out both annotations.

Copy link
Member

@alpeb alpeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@adleong adleong merged commit 2d3f3d3 into main Aug 9, 2023
35 checks passed
@adleong adleong deleted the alex/remote-discovery-improvements branch August 9, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants