Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output upgrade instructions #2575

Closed
grampelberg opened this issue Mar 27, 2019 · 4 comments
Closed

Output upgrade instructions #2575

grampelberg opened this issue Mar 27, 2019 · 4 comments
Assignees
@scottcarol
Labels
area/cli priority/P0 Release Blocker

Comments

@grampelberg
Copy link
Contributor

Feature Request

What problem are you trying to solve?

Upgrading between versions is more than just the control plane. #2556 covers providing a command, but it only outputs YAML. There are breaking changes, specific upgrade steps and gotchas when going between versions.

How should the problem be solved?

Output a URL that provides the full upgrade instructions between versions as part of the CLI output. This way, users can go read up before then apply to the cluster and follow the steps.
@scottcarol
Copy link
Contributor

@grampelberg Is the URL a link to a new page on linkerd.io, maybe https://linkerd.io/2/upgrade-help? Does this issue include creating that new page, with upgrade instructions?

@grampelberg
Copy link
Contributor Author

https://linkerd.io/2/tasks/upgrade/ would be where it would go eventually. We should have a redirect in place that goes there though (take a look at how check's been done).

@scottcarol
Copy link
Contributor

Should the URL be output only if the user types linkerd upgrade -h | --help or should it be output any time the user types linkerd upgrade?

@grampelberg
Copy link
Contributor Author

@scottcarol any time a user types linkerd upgrade. Take a look at how inject does its output.

@scottcarol scottcarol mentioned this issue Apr 3, 2019
Merged
scottcarol pushed a commit that referenced this issue Apr 4, 2019
Output a URL with instructions after running linkerd upgrade (#2627)
e15ce7f 
Adds a URL to the `linkerd upgrade` output which contains full upgrade instructions. The message and the URL anchors are different in the case of success or failure.

Fixes #2575.
KatherineMelnyk pushed a commit to KatherineMelnyk/linkerd2 that referenced this issue Apr 5, 2019
@KatherineMelnyk
Output a URL with instructions after running linkerd upgrade (linke…
d4dd348 
…rd#2627)

Adds a URL to the `linkerd upgrade` output which contains full upgrade instructions. The message and the URL anchors are different in the case of success or failure.

Fixes linkerd#2575. 

Signed-off-by: [email protected] <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@scottcarol scottcarol

Labels
area/cli priority/P0 Release Blocker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grampelberg @scottcarol