-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Injection integration tests #2569
Labels
Comments
siggy
added a commit
that referenced
this issue
Mar 29, 2019
The integration tests were not exercising proxy auto inject. Introduce a `--proxy-auto-inject` flag to `install_test.go`, which exercises install, check, and app deploy (via smoke test) for both manual and auto injected use cases. Part of #2569 Signed-off-by: Andrew Seigner <[email protected]>
siggy
added a commit
that referenced
this issue
Mar 29, 2019
The integration tests were not exercising proxy auto inject. Introduce a `--proxy-auto-inject` flag to `install_test.go`, which exercises install, check, and app deploy (via smoke test) for both manual and auto injected use cases. Part of #2569 Signed-off-by: Andrew Seigner <[email protected]>
siggy
added a commit
that referenced
this issue
Mar 29, 2019
The integration tests were not exercising proxy auto inject. Introduce a `--proxy-auto-inject` flag to `install_test.go`, which now exercises install, check, and smoke test deploy for both manual and auto injected use cases. Part of #2569 Signed-off-by: Andrew Seigner <[email protected]>
siggy
added a commit
that referenced
this issue
Mar 29, 2019
The integration tests were not exercising proxy auto inject. Introduce a `--proxy-auto-inject` flag to `install_test.go`, which now exercises install, check, and smoke test deploy for both manual and auto injected use cases. Part of #2569 Signed-off-by: Andrew Seigner <[email protected]>
siggy
added a commit
that referenced
this issue
Apr 1, 2019
The integration tests were not exercising proxy auto inject. Introduce a `--proxy-auto-inject` flag to `install_test.go`, which now exercises install, check, and smoke test deploy for both manual and auto injected use cases. Part of #2569 Signed-off-by: Andrew Seigner <[email protected]>
Closing in favor of tracking ticket #2459. |
KatherineMelnyk
pushed a commit
to KatherineMelnyk/linkerd2
that referenced
this issue
Apr 5, 2019
The integration tests were not exercising proxy auto inject. Introduce a `--proxy-auto-inject` flag to `install_test.go`, which now exercises install, check, and smoke test deploy for both manual and auto injected use cases. Part of linkerd#2569 Signed-off-by: Andrew Seigner <[email protected]> Signed-off-by: [email protected] <[email protected]>
KatherineMelnyk
pushed a commit
to KatherineMelnyk/linkerd2
that referenced
this issue
Apr 5, 2019
The integration tests were not exercising proxy auto inject. Introduce a `--proxy-auto-inject` flag to `install_test.go`, which now exercises install, check, and smoke test deploy for both manual and auto injected use cases. Part of linkerd#2569 Signed-off-by: Andrew Seigner <[email protected]> Signed-off-by: [email protected] <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Background
Injection behavior is changing via PRs like #2500, #2547, and #2555, particularly in the interaction between manual and auto-injection.
Proposal
Introduce integration tests to validate various dimensions of injections and annotations:
--proxy-auto-inject
linkerd.io/inject: enabled
,linkerd.io/inject: disabled
, and no annotation presentPart of #2459
The text was updated successfully, but these errors were encountered: