Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Injection integration tests #2569

Closed
1 task done
siggy opened this issue Mar 26, 2019 · 1 comment
Closed
1 task done

Injection integration tests #2569

siggy opened this issue Mar 26, 2019 · 1 comment
Assignees
@siggy
Labels
area/test priority/P1 Planned for Release

Comments

@siggy
Copy link
Member

siggy commented Mar 26, 2019 •
edited
Loading

Background

Injection behavior is changing via PRs like #2500, #2547, and #2555, particularly in the interaction between manual and auto-injection.

Proposal

Introduce integration tests to validate various dimensions of injections and annotations:

  • Introduce auto inject integration tests #2595 with and without --proxy-auto-inject
  • cli inject with and without auto inject
  • pod deploys and deployment deploys
  • linkerd.io/inject: enabled, linkerd.io/inject: disabled, and no annotation present
  • pod annotations and deployment annotations
  • creating and updating

Part of #2459
@admc admc mentioned this issue Mar 26, 2019
Closed
25 tasks
@ihcsim ihcsim mentioned this issue Mar 27, 2019
Merged
@siggy siggy added the priority/P1 Planned for Release label Mar 29, 2019
@siggy siggy self-assigned this Mar 29, 2019
siggy added a commit that referenced this issue Mar 29, 2019
@siggy
Introduce auto inject integration tests
59c7467 
The integration tests were not exercising proxy auto inject.

Introduce a `--proxy-auto-inject` flag to `install_test.go`, which
exercises install, check, and app deploy (via smoke test) for both
manual and auto injected use cases.

Part of #2569

Signed-off-by: Andrew Seigner <[email protected]>
@siggy siggy mentioned this issue Mar 29, 2019
Merged
siggy added a commit that referenced this issue Mar 29, 2019
@siggy
Introduce auto inject integration tests
2531fff 
The integration tests were not exercising proxy auto inject.

Introduce a `--proxy-auto-inject` flag to `install_test.go`, which
exercises install, check, and app deploy (via smoke test) for both
manual and auto injected use cases.

Part of #2569

Signed-off-by: Andrew Seigner <[email protected]>
siggy added a commit that referenced this issue Mar 29, 2019
@siggy
Introduce auto inject integration tests
a66735e 
The integration tests were not exercising proxy auto inject.

Introduce a `--proxy-auto-inject` flag to `install_test.go`, which
now exercises install, check, and smoke test deploy for both manual and
auto injected use cases.

Part of #2569

Signed-off-by: Andrew Seigner <[email protected]>
siggy added a commit that referenced this issue Mar 29, 2019
@siggy
Introduce auto inject integration tests
807e73d 
The integration tests were not exercising proxy auto inject.

Introduce a `--proxy-auto-inject` flag to `install_test.go`, which
now exercises install, check, and smoke test deploy for both manual and
auto injected use cases.

Part of #2569

Signed-off-by: Andrew Seigner <[email protected]>
siggy added a commit that referenced this issue Apr 1, 2019
@siggy
Introduce auto inject integration tests (#2595)
b454f8f 
The integration tests were not exercising proxy auto inject.

Introduce a `--proxy-auto-inject` flag to `install_test.go`, which
now exercises install, check, and smoke test deploy for both manual and
auto injected use cases.

Part of #2569

Signed-off-by: Andrew Seigner <[email protected]>
@siggy
Copy link
Member Author

siggy commented Apr 1, 2019

Closing in favor of tracking ticket #2459.

@siggy siggy closed this as completed Apr 1, 2019
KatherineMelnyk pushed a commit to KatherineMelnyk/linkerd2 that referenced this issue Apr 5, 2019
@siggy @KatherineMelnyk
Introduce auto inject integration tests (linkerd#2595)
c76f0fc 
The integration tests were not exercising proxy auto inject.

Introduce a `--proxy-auto-inject` flag to `install_test.go`, which
now exercises install, check, and smoke test deploy for both manual and
auto injected use cases.

Part of linkerd#2569

Signed-off-by: Andrew Seigner <[email protected]>
Signed-off-by: [email protected] <[email protected]>
KatherineMelnyk pushed a commit to KatherineMelnyk/linkerd2 that referenced this issue Apr 5, 2019
@siggy @KatherineMelnyk
Introduce auto inject integration tests (linkerd#2595)
76c60fe 
The integration tests were not exercising proxy auto inject.

Introduce a `--proxy-auto-inject` flag to `install_test.go`, which
now exercises install, check, and smoke test deploy for both manual and
auto injected use cases.

Part of linkerd#2569

Signed-off-by: Andrew Seigner <[email protected]>
Signed-off-by: [email protected] <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@siggy siggy

Labels
area/test priority/P1 Planned for Release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@siggy