Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI Inject With Proxy Config Overrides Annotations #2447

Closed
ihcsim opened this issue Mar 5, 2019 · 2 comments
Closed

CLI Inject With Proxy Config Overrides Annotations #2447

ihcsim opened this issue Mar 5, 2019 · 2 comments
Assignees
Labels

Comments

@ihcsim
Copy link
Contributor

ihcsim commented Mar 5, 2019

Provide a mechanism to override the configurations of a proxy during linkerd inject. By default, if no flags are provided, the proxy will inherit the configurations specified in the linkerd-config config map during CLI inject. If present, the config flags should be converted into annotations on the pod spec before being passed to the proxy-injector. The proxy-injector will then perform the configs overrides per #2287.

Depending on whether the YAML defines a single pod or a workflow resource, the CLI will have to insert the annotations at different levels (i.e. metadata.annotations and spec.template.metadata.annotations).

Depends on #2287.

@klingerf
Copy link
Contributor

klingerf commented Mar 6, 2019

I just wanted to clarify that once we've added the new public API config endpoint (#2455) and updated the CLI to call that endpoint (#2434), the CLI can apply flag overrides directly to the config before calling the inject library. There won't be any need to convert the flags to annotations on the pod spec, and this change won't be blocked on needing the inject library to honor pod spec annotations (#2287).

@ihcsim
Copy link
Contributor Author

ihcsim commented Mar 19, 2019

Per discussion with @klingerf, the step to convert the CLI inject proxy options to annotations is still necessary, to ensure that subsequent updates (via kubectl apply etc.) don't override the existing proxy configs. The current override logic will always look for config annotations, before falling back to defaults defined in the linkerd-config config map.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants