Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor linkerd inject to make use of the new endpoint for injecting the proxy #2288

Closed
alpeb opened this issue Feb 14, 2019 · 3 comments
Closed

Refactor linkerd inject to make use of the new endpoint for injecting the proxy #2288

alpeb opened this issue Feb 14, 2019 · 3 comments
Labels
area/cli area/inject area/install

Comments

@alpeb
Copy link
Member

alpeb commented Feb 14, 2019

Depends on #2286
@alpeb alpeb mentioned this issue Feb 14, 2019
Closed
@klingerf
Copy link
Contributor

Just a quick clarifying comment here: we should update linkerd inject to make use of the new endpoint, but for linkerd install we'll still need to use a library to inject the control plane install config, since the control plane won't be available at the time that the install config is generated.

@alpeb
Copy link
Member Author

alpeb commented Feb 14, 2019

@klingerf thanks for the clarification, that makes sense.

@klingerf klingerf mentioned this issue Feb 14, 2019
Merged
@ihcsim ihcsim changed the title Refactor linkerd install and linkerd inject to make use of the new endpoint for injecting the proxy Refactor linkerd inject to make use of the new endpoint for injecting the proxy Feb 15, 2019
@alpeb alpeb self-assigned this Feb 18, 2019
@ihcsim ihcsim assigned ihcsim and unassigned alpeb Feb 22, 2019
@ihcsim ihcsim removed their assignment Feb 26, 2019
@alpeb
Copy link
Member Author

alpeb commented Mar 22, 2019

This has been superseded by #2447

@alpeb alpeb closed this as completed Mar 22, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area/cli area/inject area/install
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@klingerf @alpeb @ihcsim