You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The `--log-level` flag did not support a `trace` level, despite the
underlying `logrus` library supporting it. Also, at `debug` level, the
Control Plane components were setting klog at v=12, which includes
sensitive data.
Introduce a `trace` log level. Keep klog at `v=12` for `trace`, change
it to `v=6` for `debug`.
Fixes#11132
Signed-off-by: Andrew Seigner <[email protected]>
The `--log-level` flag did not support a `trace` level, despite the
underlying `logrus` library supporting it. Also, at `debug` level, the
Control Plane components were setting klog at v=12, which includes
sensitive data.
Introduce a `trace` log level. Keep klog at `v=12` for `trace`, change
it to `v=6` for `debug`.
Fixes#11132
Signed-off-by: Andrew Seigner <[email protected]>
What problem are you trying to solve?
In the Go-based Control Plane components, the
debug
log level is quite verbose. This is the highest log level available in the Control Plane:linkerd2/pkg/flags/flags.go
Lines 36 to 37 in d0e837d
Also, the
debug
log level sets klog tov=12
, potentially exposing sensitive authorization tokens:linkerd2/pkg/flags/flags.go
Line 72 in d0e837d
How should the problem be solved?
Introduce a
trace
log level. Change debug to klogv=6
, settrace
atv=12
:Any alternatives you've considered?
Don't use debug logs.
How would users interact with this feature?
Via helm and CLI flags.
Would you like to work on this feature?
maybe
The text was updated successfully, but these errors were encountered: