Skip to content

Commit

Permalink
Improve debugging in dualstack integration test (#13193)
Browse files Browse the repository at this point in the history
This test has been sporadically flakey, so we add here the `-S` and
`--stderr -` flags to the cURL command to show in stdout the actual
errors.
  • Loading branch information
alpeb authored Oct 21, 2024
1 parent 72beec7 commit 4b83336
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions test/integration/deep/dualstack/dualstack_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ func TestMain(m *testing.M) {
// IPv6 endpoint.
func TestDualStack(t *testing.T) {
if !TestHelper.DualStack() {
t.Skip("Skipping Skip DualStack test")
t.Skip("Skipping DualStack test")
}

TestHelper.WithDataPlaneNamespace(context.Background(), "dualstack-test", map[string]string{}, t, func(t *testing.T, ns string) {
Expand Down Expand Up @@ -120,7 +120,7 @@ func TestDualStack(t *testing.T) {
"-c", "curl",
"-n", ns,
"--",
"curl", "-s", "http://"+serverIPv4+":8080",
"curl", "-s", "-S", "--stderr", "-", "http://"+serverIPv4+":8080",
)
if err != nil {
testutil.AnnotatedFatalf(t, "unexpected error", "unexpected error: %v\noutput:\n%s", err, out)
Expand All @@ -136,7 +136,7 @@ func TestDualStack(t *testing.T) {
"-c", "curl",
"-n", ns,
"--",
"curl", "-s", "http://["+serverIPv6+"]:8080",
"curl", "-s", "-S", "--stderr", "-", "http://["+serverIPv6+"]:8080",
)
if err != nil {
testutil.AnnotatedFatalf(t, "unexpected error", "unexpected error: %v\noutput:\n%s", err, out)
Expand All @@ -153,7 +153,7 @@ func TestDualStack(t *testing.T) {
"-c", "curl",
"-n", ns,
"--",
"curl", "-s", "http://ipfamilies-server:8080",
"curl", "-s", "-S", "--stderr", "-", "http://ipfamilies-server:8080",
)
if err != nil {
testutil.AnnotatedFatalf(t, "unexpected error", "unexpected error: %v\noutput:\n%s", err, out)
Expand Down

0 comments on commit 4b83336

Please sign in to comment.