Skip to content

Commit

Permalink
ci: Make errors fatal
Browse files Browse the repository at this point in the history
We have `continue-on-error: true` marked on several integration
workflows. It appears that GitHub's behavior has changed to now mark
these tests as green even when they fail.

This change removes this setting from integration tests so errors are
reported properly.
  • Loading branch information
olix0r committed Nov 17, 2023
1 parent f075cb3 commit 42ebf6e
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,6 @@ jobs:
test:
- cni-calico-deep
- deep
continue-on-error: true
runs-on: ubuntu-20.04
timeout-minutes: 15
steps:
Expand Down Expand Up @@ -262,7 +261,6 @@ jobs:
- uninstall
- upgrade-edge
- upgrade-stable
continue-on-error: true
runs-on: ubuntu-20.04
timeout-minutes: 15
steps:
Expand Down Expand Up @@ -305,7 +303,6 @@ jobs:
test-viz:
needs: [tag, changed-viz, build-cli, build-core, build-ext]
if: needs.changed-viz.outputs.modified == 'true'
continue-on-error: true
runs-on: ubuntu-20.04
timeout-minutes: 15
steps:
Expand Down

0 comments on commit 42ebf6e

Please sign in to comment.