chore(http/upgrade): replace hyper::Body with BoxBody
#3479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`hyper::Body` is removed in the 1.0 version. this commit removes it from our upgrade facilities, using a generic body parameter that defaults to BoxBody. see <linkerd/linkerd2#8733>. Signed-off-by: katelyn martin <[email protected]>
cratelyn
added a commit
that referenced
this pull request
Dec 20, 2024
`UpgradeResponseBody` currently wraps a `hyper::Body`. this type is removed in hyper 1.0. this commit replaces this with a generic `B`-typed body. see #3479, which performs the same change in `linkerd-http-upgrade`. see linkerd/linkerd2#8733 for more information on upgrading to hyper 1.0. Signed-off-by: katelyn martin <[email protected]>
sfleen
approved these changes
Dec 20, 2024
https://github.com/linkerd/linkerd2-proxy/pull/3479/files#r1894068885 in `main` this isn't currently pinned, so this was needed to add the `B` parameter originally in development, but tweaking how we poll the body (_see lines 70-80, below_) means this bound is indeed frivolous now. this commit removes an extraneous `Unpin` bound. Co-authored-by: Scott Fleener <[email protected]> Signed-off-by: katelyn martin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hyper::Bodyis removed in the 1.0 version.this commit removes it from our upgrade facilities, using a generic body parameter that defaults to BoxBody.
see linkerd/linkerd2#8733.