refactor(proxy/http): extricate Body middleware types
#3382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfleen
approved these changes
Nov 22, 2024
Cargo.toml
Outdated
| @@ -85,7 +87,7 @@ members = [ | |||
| "opencensus-proto", | |||
| "opentelemetry-proto", | |||
| "spiffe-proto", | |||
| "tools", | |||
| "tools", "linkerd/http/override-authority", | |||
There was a problem hiding this comment.
format nit: sort and put on it's own line
There was a problem hiding this comment.
thank you for spotting this!
this is moved onto its own sorted line in the amended commit 5f9c146
| @@ -23,6 +26,27 @@ pub struct OverrideAuthority<S, H> { | |||
| inner: S, | |||
| } | |||
|
|
|||
| /// Sets the [`Authority`][uri::Authority] of the given URI. | |||
There was a problem hiding this comment.
optional: This can just be [`Authority`] since it's already imported, but I'm not sure what our style guidelines are around this.
There was a problem hiding this comment.
good catch, thanks! i appreciate the close eye. 🦅
this is fixed in the amended commit 5f9c146
cratelyn
force-pushed
the
kate/yoink-http-body-middleware
branch
2 times, most recently
from
5f9c146 to
1631681
Compare
|
rebased to address a minor typo in a commit message 👼 |
cratelyn
added a commit
that referenced
this pull request
Nov 22, 2024
in this case we already had a crate defining the classify traits, but the http body and other assorted middleware were defined in `linkerd-proxy-http`. this commit moves those types to the `linkerd-http-classify` crate, which astute readers may notice, is a concrete step towards simplifying the `linkerd-proxy-http` crate's upgrade process. one small detail worth calling out: we implement `http_body::Body` directly, to avoid taking on a `hyper` dependency. otherwise, nothing has changed in the `channel`, `gate`, and `insert` middleware. Signed-off-by: katelyn martin <[email protected]>
cratelyn
added a commit
that referenced
this pull request
Nov 22, 2024
this moves the `Retain` middleware from `linkerd-proxy-http` into a new `linkerd-http-retain` crate. as previously, reëxports are added to make this a backwards compatible change. this moves another http body middleware out of the proxy's core http crate. great news. Signed-off-by: katelyn martin <[email protected]>
cratelyn
added a commit
that referenced
this pull request
Nov 22, 2024
) this commit outlines the stream timeout middleware, pulling it out of `linkerd-proxy-http` and into a standalone crate. again, reëxports are added to make this a backwards compatible change. Signed-off-by: katelyn martin <[email protected]>
cratelyn
added a commit
that referenced
this pull request
Nov 22, 2024
…3382) NB: based on #3379 and #3380. this pull the `override_authority` submodule out of `linkerd-http-proxy` and into a standalone crate. Signed-off-by: katelyn martin <[email protected]>
cratelyn
force-pushed
the
kate/yoink-http-body-middleware
branch
from
1631681 to
7f564f9
Compare
in this case we already had a crate defining the classify traits, but the http body and other assorted middleware were defined in `linkerd-proxy-http`. this commit moves those types to the `linkerd-http-classify` crate, which astute readers may notice, is a concrete step towards simplifying the `linkerd-proxy-http` crate's upgrade process. one small detail worth calling out: we implement `http_body::Body` directly, to avoid taking on a `hyper` dependency. otherwise, nothing has changed in the `channel`, `gate`, and `insert` middleware. Signed-off-by: katelyn martin <[email protected]>
this moves the `Retain` middleware from `linkerd-proxy-http` into a new `linkerd-http-retain` crate. as previously, reëxports are added to make this a backwards compatible change. this moves another http body middleware out of the proxy's core http crate. great news. Signed-off-by: katelyn martin <[email protected]>
) this commit outlines the stream timeout middleware, pulling it out of `linkerd-proxy-http` and into a standalone crate. again, reëxports are added to make this a backwards compatible change. Signed-off-by: katelyn martin <[email protected]>
…3382) NB: based on #3379 and #3380. this pull the `override_authority` submodule out of `linkerd-http-proxy` and into a standalone crate. Signed-off-by: katelyn martin <[email protected]>
cratelyn
force-pushed
the
kate/yoink-http-body-middleware
branch
from
7f564f9 to
cb9f511
Compare
this is only used in once place, so as a brief chore before we move the upgrade submodule out into its own crate, we pull `is_bad_request()` next to its call site. Signed-off-by: katelyn martin <[email protected]>
this moves the inter-related `upgrade` and `glue` submodules out of the `linkerd-proxy-http` library and into a new standalone crate. Signed-off-by: katelyn martin <[email protected]>
cratelyn
force-pushed
the
kate/yoink-http-body-middleware
branch
from
cb9f511 to
61d2a63
Compare
|
rebased onto the latest |
olix0r
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this branch pulls a number of components providing
http_body::Bodymiddleware out oflinkerd-proxy-httpand into new libraries:linkerd-http-classify,linkerd-http-stream-timeouts,linkerd-http-retain, andlinkerd-http-override-authority.these are each performed in distinct commits, to facilitate review.