Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rate-limiters to ServerPolicy #3305

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Commits on Oct 29, 2024

  1. Add rate-limiters to ServerPolicy

    This adds the local_rate_limit module to the server-policy crate, that
    `ServerPolicy` uses for its new `local_rate_limit` field, containing
    three optional rate-limiters: total, identity, overrides (this one is
    really a vector of limiters, one per configured override).
    
    I tried putting that under `Protocol` instead, but the `PartialEq`
    requirement made it very hard to follow. `Server` OTOH doesn't really
    require that trait, so I was able to remove it and accommodate the
    limiters.
    
    I made sure to avoid pulling the dashmap dependency in `governor`; I
    haven't checked yet the necessity of the "jitter" and "quanta" features.
    
    This temporarily overrides linkerd2-proxy-api dependency to pick changes
    from linkerd/linkerd2-proxy-api#388
    alpeb committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    b580e65 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. feedback

    alpeb committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    6d9a4a7 View commit details
    Browse the repository at this point in the history