📈 feat(rt): expose tokio runtime metrics #3177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olix0r
reviewed
Sep 5, 2024
olix0r
reviewed
Sep 5, 2024
cratelyn
commented
Sep 5, 2024
|
this still needs to wire up changes to release.yml to enable the |
cratelyn
force-pushed
the
kate/expose-tokio-runtime-metrics-wip
branch
2 times, most recently
from
662c146
to
7c08a0c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
cratelyn
force-pushed
the
kate/expose-tokio-runtime-metrics-wip
branch
2 times, most recently
from
524445c
to
415e459
Compare
This comment was marked as resolved.
This comment was marked as resolved.
cratelyn
force-pushed
the
kate/expose-tokio-runtime-metrics-wip
branch
from
50b89b9
to
34e91ba
Compare
cratelyn
commented
Sep 6, 2024
cratelyn
force-pushed
the
kate/expose-tokio-runtime-metrics-wip
branch
from
34e91ba
to
b65de6a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
cratelyn
force-pushed
the
kate/expose-tokio-runtime-metrics-wip
branch
from
673c77f
to
93fde9f
Compare
Signed-off-by: katelyn martin <[email protected]>
Signed-off-by: katelyn martin <[email protected]>
Signed-off-by: katelyn martin <[email protected]>
cratelyn
force-pushed
the
kate/expose-tokio-runtime-metrics-wip
branch
2 times, most recently
from
5a9aeee
to
bc19e6d
Compare
Tokio has an unstable feature supporting runtime metrics. This allows service operators to export metrics to systems like Prometheus, so that they can observe how their workloads are performing on the tokio runtime. This exposes information like the number of worker threads, queue depth, the number of tasks polled, and so on. `linkerd2-proxy` should expose these metrics. This uses the `kubert-prometheus-tokio` crate to register a `Runtime` metrics worker, and spawn a task to probe these metrics at a fixed, regular interval. see: <https://github.com/olix0r/kubert/tree/main/kubert-prometheus-tokio> if the `tokio_unstable` feature is not enabled, this will emit a debug event and do nothing. Signed-off-by: katelyn martin <[email protected]>
cratelyn
force-pushed
the
kate/expose-tokio-runtime-metrics-wip
branch
from
bc19e6d
to
b4496a0
Compare
|
@olix0r this branch is now ready for another round of review 🔍 thank you for your assistance in diagnosing runtime panics! |
Co-authored-by: Oliver Gould <[email protected]> Signed-off-by: katelyn martin <[email protected]>
cratelyn
force-pushed
the
kate/expose-tokio-runtime-metrics-wip
branch
from
5230cf8
to
0285e8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tokio has an unstable feature supporting runtime metrics.
This allows service operators to export metrics to systems like
Prometheus, so that they can observe how their workloads are performing
on the tokio runtime. This exposes information like the number of worker
threads, queue depth, the number of tasks polled, and so on.
linkerd2-proxyshould expose these metrics.This uses the
kubert-prometheus-tokiocrate to register aRuntimemetrics worker, and spawn a task to probe these metrics at a fixed,
regular interval.
see: https://github.com/olix0r/kubert/tree/main/kubert-prometheus-tokio
if the
tokio_unstablefeature is not enabled, this will emit a debugevent and do nothing.