Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

balance: Log and fail stuck discovery streams. #2484

Merged
merged 2 commits into from
Oct 17, 2023
Merged

balance: Log and fail stuck discovery streams. #2484

merged 2 commits into from
Oct 17, 2023

Commits on Oct 17, 2023

  1. balance: Log and fail stuck discovery streams. 

    In 6d2abbc, we changed how outbound proxies process discovery updates.
The prior implementation used a watchdog timeout to bound the amount of
time an update stream could be full. With that change, when an update
channel fills, the backpressure can extend to the destination
controller's gRPC response stream.

To detect and avoid this harmful (and useless) backpressure, this change
modifies the balancer's discovery processing stream to exit when the
balancer has 1000 unprocessed discovery updates. A sufficiently scary
warning is logged.
    @olix0r
    olix0r committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    b4b6db9 View commit details
    Browse the repository at this point in the history

  2. fback

    @olix0r
    olix0r committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    99bd189 View commit details
    Browse the repository at this point in the history