Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Decouple HTTP and TCP buffering config #2078

Merged
merged 16 commits into from
Dec 27, 2022
Merged

config: Decouple HTTP and TCP buffering config #2078

merged 16 commits into from
Dec 27, 2022

Commits on Dec 16, 2022

  1. wip: buffers

    olix0r committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    8d0d573 View commit details
    Browse the repository at this point in the history
  2. make each buffer configurable

    olix0r committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    c1bc339 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9fe1f22 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2022

  1. Configuration menu
    Copy the full SHA
    b1972b7 View commit details
    Browse the repository at this point in the history
  2. Use BufferConfig directly

    olix0r committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    cbc7758 View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2022

  1. Restore concurrency limit

    olix0r committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    a211d3e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c7922a4 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2022

  1. Configuration menu
    Copy the full SHA
    6a93036 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9ebb0a8 View commit details
    Browse the repository at this point in the history
  3. TODOs

    olix0r committed Dec 27, 2022
    Configuration menu
    Copy the full SHA
    9afd8fb View commit details
    Browse the repository at this point in the history
  4. typo

    olix0r committed Dec 27, 2022
    Configuration menu
    Copy the full SHA
    9e8e0bf View commit details
    Browse the repository at this point in the history
  5. config: Decouple HTTP and TCP buffering config

    Proxies may buffer TCP connections while waiting for policy discovery
    and may buffer HTTP requests while waiting for a shared resource (like a
    load balancer).
    
    Previously, a single configuration was used to configure both TCP and
    HTTP buffers. This change decouples these configurations in preparation
    for allowing balancer configuration to be configured by the control
    plane.
    
    Furthermore, this change updates the stack builder to always construct
    buffers with failfast and spawnready to (1) ensure that all buffers
    enforce the proper backpressure and load shedding semantics and (2) to
    reduce boilerplate.
    
    This change updates the proxy's environment configuration as follows:
    
    * Removed `LINKERD2_PROXY_INBOUND_DISPATCH_TIMEOUT`
    * Removed `LINKERD2_PROXY_OUTBOUND_DISPATCH_TIMEOUT`
    * Added `LINKERD2_PROXY_INBOUND_DISCOVERY_IDLE_TIMEOUT`
    * Added `LINKERD2_PROXY_OUTBOUND_DISCOVERY_IDLE_TIMEOUT`
    * Removed `LINKERD2_PROXY_BUFFER_CAPACITY`
    * Removed `LINKERD2_PROXY_INBOUND_ROUTER_MAX_IDLE_AGE`
    * Removed `LINKERD2_PROXY_OUTBOUND_ROUTER_MAX_IDLE_AGE`
    * Added `LINKERD2_PROXY_INBOUND_HTTP_BUFFER_CAPACITY`
    * Added `LINKERD2_PROXY_INBOUND_HTTP_FAILFAST_TIMEOUT`
    * Added `LINKERD2_PROXY_OUTBOUND_TCP_BUFFER_CAPACITY`
    * Added `LINKERD2_PROXY_OUTBOUND_TCP_FAILFAST_TIMEOUT`
    * Added `LINKERD2_PROXY_OUTBOUND_HTTP_BUFFER_CAPACITY`
    * Added `LINKERD2_PROXY_OUTBOUND_HTTP_FAILFAST_TIMEOUT`
    * Added `LINKERD2_PROXY_OUTBOUND_HTTP1_CONNECTION_POOL_IDLE_TIMEOUT`
    olix0r committed Dec 27, 2022
    Configuration menu
    Copy the full SHA
    671ca3e View commit details
    Browse the repository at this point in the history
  6. fixup stack + tests

    olix0r committed Dec 27, 2022
    Configuration menu
    Copy the full SHA
    ab86158 View commit details
    Browse the repository at this point in the history
  7. +comment

    olix0r committed Dec 27, 2022
    Configuration menu
    Copy the full SHA
    f37d087 View commit details
    Browse the repository at this point in the history
  8. fixup comments

    olix0r committed Dec 27, 2022
    Configuration menu
    Copy the full SHA
    1729b8b View commit details
    Browse the repository at this point in the history
  9. rename env: s/BUFFER/QUEUE

    olix0r committed Dec 27, 2022
    Configuration menu
    Copy the full SHA
    90715b5 View commit details
    Browse the repository at this point in the history