[vpj] Fix DATASET_CHANGED tracking for Spark jobs #1513
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
DATASET_CHANGED
tracking for Spark jobsIn Spark ComputeJob, some cases of
DATASET_CHANGED
were not getting tracked correctly, and were instead getting tracked asSTART_DATA_WRITER_JOB
.This was because of an incorrect assumption that Spark jobs would get executed only when the final action stage is encountered. But in practice, the spark stages were starting to get executed when the
repartitionAndSortWithinPartitions
call was getting invoked. This was previously done in theconfigure
phase, and exceptions thrown in this stage are not handled as errors during the execution of the compute job.This commit moves all Spark execution logic inside the
runComputeJob
method insteadHow was this PR tested?
GH CI
Does this PR introduce any user-facing changes?