Added infrastructure to safely bump flake8 version #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvezdan
reviewed
Dec 10, 2019
...lugin/src/integTest/groovy/com/linkedin/gradle/python/tasks/Flake8TaskIntegrationTest.groovy
Outdated
Show resolved
Hide resolved
...lugin/src/integTest/groovy/com/linkedin/gradle/python/tasks/Flake8TaskIntegrationTest.groovy
Outdated
Show resolved
Hide resolved
pygradle-plugin/src/main/groovy/com/linkedin/gradle/python/tasks/Flake8Task.java
Outdated
Show resolved
Hide resolved
pygradle-plugin/src/main/groovy/com/linkedin/gradle/python/tasks/Flake8Task.java
Outdated
Show resolved
Hide resolved
pygradle-plugin/src/main/groovy/com/linkedin/gradle/python/tasks/Flake8Task.java
Outdated
Show resolved
Hide resolved
pygradle-plugin/src/main/groovy/com/linkedin/gradle/python/tasks/Flake8Task.java
Outdated
Show resolved
Hide resolved
Added logic in the Flake8Task to rerun the execution with ignoring a set of rules if the first execution fails. It will rerun if the IGNORE_RULES set it non-empty. This set of rules will contain any rules/checks added between flake8 versions. For example, when we bump to flake8 3.8.0, we should update the IGNORE_RULES value to hold all rules and checks added between flake8 3.6.0 and 3.8.0. If the second run, when ignoring newly added rules, succeeds, we now emit a warning to the user stating which rules are being ignored, and which of these ignored rules failed for them. Added a method called overrideIgnoreRules() which is used for integration testings and will be used internally by LI. Integration tests were added to verify this new functionality.
zvezdan
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added logic in the Flake8Task to rerun the execution with ignoring
a set of rules if the first execution fails. It will rerun if the
IGNORE_RULES set it non-empty. This set of rules will contain
any rules/checks added between flake8 versions. For example, when
we bump to flake8 3.8.0, we should update the IGNORE_RULES value
to hold all rules and checks added between flake8 3.6.0 and 3.8.0.
If the second run, when ignoring newly added rules, succeeds, we
now emit a warning to the user stating which rules are being
ignored, and which of these ignored rules failed for them. Added a
method called overrideIgnoreRules() which is used for integration
testings and will be used internally by LI. Integration tests
were added to verify this new functionality.