Always enforce a ttl on snapshot expiration jobs even if unconfigured #281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue] Briefly discuss the summary of the changes made in this
pull request in 2-3 lines.
Currently it is possible to define tables with an version count, and the snapshot expiration job will respect the version count instead of enforcing a TTL. With this change the snapshot expiration job will always enforce a TTL, defaulted currently to 3 days. This cannot be overridden by users unless they explicitly define a TTL that is greater than 3 days (but is currently the maximum is 3 days due to the history configuration validator)
openhouse/services/tables/src/main/java/com/linkedin/openhouse/tables/api/validator/impl/HistoryPolicySpecValidator.java
Line 57 in 7f66a73
Also fix some bugs where
TableSnapshotExpirationTask
is not sending properties correctly from the JobSchedulerChanges
For all the boxes checked, please include additional details of the changes made in this pull request.
Testing Done
Tested E2E with acceptance tests from local
For all the boxes checked, include a detailed description of the testing done for the changes made in this pull request.
Additional Information
For all the boxes checked, include additional details of the changes made in this pull request.