-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replication job to trigger setup and carbon flow for replica tables [WIP] #276
Merged
rohitkum2506
merged 5 commits into
linkedin:main
from
rohitkum2506:rohikuma/ReplicationJob
Jan 10, 2025
Merged
Replication job to trigger setup and carbon flow for replica tables [WIP] #276
rohitkum2506
merged 5 commits into
linkedin:main
from
rohitkum2506:rohikuma/ReplicationJob
Jan 10, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
727def4
to
4ceabdd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rohitkum2506. Did initial pass and added some comments.
apps/spark/src/main/java/com/linkedin/openhouse/jobs/scheduler/tasks/TableReplicationTask.java
Outdated
Show resolved
Hide resolved
apps/spark/src/main/java/com/linkedin/openhouse/jobs/util/ReplicationConfig.java
Outdated
Show resolved
Hide resolved
apps/spark/src/main/java/com/linkedin/openhouse/jobs/client/TablesClient.java
Show resolved
Hide resolved
apps/spark/src/main/java/com/linkedin/openhouse/jobs/scheduler/tasks/TableReplicationTask.java
Outdated
Show resolved
Hide resolved
apps/spark/src/main/java/com/linkedin/openhouse/jobs/scheduler/tasks/TableReplicationTask.java
Outdated
Show resolved
Hide resolved
apps/spark/src/main/java/com/linkedin/openhouse/jobs/scheduler/tasks/OperationTasksBuilder.java
Show resolved
Hide resolved
abhisheknath2011
approved these changes
Jan 10, 2025
apps/spark/src/main/java/com/linkedin/openhouse/jobs/client/TablesClient.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
New job workflow to run Replication setup process on Airflow. Applies to primary tables with defined ReplicationConfig.
Design decisions:
Instead it will use Airflow client to trigger and manage lifecycle of a Airflow job.
Future work:
Changes
For all the boxes checked, please include additional details of the changes made in this pull request.
Testing Done
Tested on Local docker setup:
Ran the new Replication Job with Local Docker setup. Added a table with replicationConfig.
Observed:
For all the boxes checked, include a detailed description of the testing done for the changes made in this pull request.
Additional Information
For all the boxes checked, include additional details of the changes made in this pull request.