-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1/5] Set up basic Azure sandbox environment, providers, etc. #136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 @kmcclenn This is a crisp PR. I left some comments directly in the code for you to accept if you agree with suggestion
infra/recipes/terraform/azure/environments/sandbox/config.azurerm.tfbackend
Outdated
Show resolved
Hide resolved
infra/recipes/terraform/azure/environments/sandbox/variables.tf
Outdated
Show resolved
Hide resolved
infra/recipes/terraform/azure/environments/sandbox/terraform.tfvars
Outdated
Show resolved
Hide resolved
infra/recipes/terraform/azure/environments/sandbox/variables.tf
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 Great work Kai! Once you have test it update the testing done section with the details.
Code wise it looks great to me, and I don't have further feedback. Any issues you find in testing, go ahead and push them to this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Kai for the changes! It looks much organized now. Added some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @kmcclenn 💯 work!
├── provider.tf # Specific variables used for the kubernetes provider configuration | ||
├── provider.tf # The global azure and other providers needed for the configurations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
├── provider.tf # Specific variables used for the kubernetes provider configuration | |
├── provider.tf # The global azure and other providers needed for the configurations | |
├── provider.tf # Specific variables used for the kubernetes provider configuration | |
├── provider.tf # The global azure and other providers needed for the configurations |
Two provider.tf
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. I will remove one.
Co-authored-by: Sumedh Sakdeo <[email protected]>
Co-authored-by: Sumedh Sakdeo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kmcclenn. Looks Great!
Summary
Added the basic environment setup for configuration with Azure. Used terraform to add backend, providers, and resource group configuration. Similar to PR #129 but split up into 5 parts.
PR 1: #136 (terraform backend)
PR 2: kmcclenn#3 (VM)
PR 3: kmcclenn#4 (MySQL)
PR 4: kmcclenn#5 (k8s)
PR 5: kmcclenn#6 (Storage Account)
Changes
Testing Done
Ran the commands as specified in the README. All of the services ran, and for confirmation they appeared in my Azure portal.
Additional Information
For all the boxes checked, include additional details of the changes made in this pull request.