-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring auth init and adding tests #133
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbb330
force-pushed
the
main
branch
2 times, most recently
from
July 10, 2024 06:09
244c389
to
6a8e224
Compare
cbb330
commented
Jul 10, 2024
cluster/configs/src/main/java/com/linkedin/openhouse/cluster/configs/ClusterPropertiesUtil.java
Show resolved
Hide resolved
cbb330
commented
Jul 10, 2024
services/tables/src/main/java/com/linkedin/openhouse/tables/config/TablesMvcConfigurer.java
Show resolved
Hide resolved
cbb330
commented
Jul 10, 2024
services/tables/src/main/java/com/linkedin/openhouse/tables/config/TablesMvcConfigurer.java
Show resolved
Hide resolved
cbb330
commented
Jul 10, 2024
services/tables/src/main/java/com/linkedin/openhouse/tables/config/TablesMvcConfigurer.java
Show resolved
Hide resolved
cbb330
commented
Jul 10, 2024
services/tables/src/main/java/com/linkedin/openhouse/tables/config/TablesMvcConfigurer.java
Show resolved
Hide resolved
17 tasks
cbb330
changed the title
WIP: Documenting bearer token in API for swagger-ui and code generated clients
Refactoring auth init and adding tests
Jul 28, 2024
autumnust
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor questions, otherwise LGTM
services/tables/src/main/java/com/linkedin/openhouse/tables/config/TablesMvcConfigurer.java
Show resolved
Hide resolved
services/tables/src/main/java/com/linkedin/openhouse/tables/config/TablesMvcConfigurer.java
Show resolved
Hide resolved
services/tables/src/main/java/com/linkedin/openhouse/tables/config/TablesMvcConfigurer.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
problem: 1) auth requirement is not documented in swagger UI 2) auth interceptor init is not tested
(for context, this PR is from a ticket that is meant for me to onboard to the team and learn the code. as part of skilling up I've used refactoring to learn the code better. also, a lot of this code was made in an attempt to add custom headers as types exposed in our client SDK which turned out to be more complexity than it is worth.)
changes:
still TODO:
Changes
For all the boxes checked, please include additional details of the changes made in this pull request.
Testing Done
added several unittests:
Additional Information
For all the boxes checked, include additional details of the changes made in this pull request.