Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make snapshots expiration job leaner #131

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Conversation

teamurko
Copy link
Collaborator

@teamurko teamurko commented Jul 5, 2024

Summary

Snapshots expiration job skips removing files as we wanted to localize files removal to one job. The job traverses the files tree though, and that is expensive and unnecessary. As the result of this change, it updates snapshots list in the metadata without traversing the files tree.

Changes

  • Client-facing API Changes
  • Internal API Changes
  • Bug Fixes
  • New Features
  • Performance Improvements
  • Code Style
  • Refactoring
  • Documentation
  • Tests

For all the boxes checked, please include additional details of the changes made in this pull request.

Testing Done

  • Manually Tested on local docker setup. Please include commands ran, and their output.
  • Added new tests for the changes made.
  • Updated existing tests to reflect the changes made.
  • No tests added or updated. Please explain why. If unsure, please feel free to ask for help.
  • Some other form of testing like staging or soak time in production. Please explain.

No change in the job effect is expected, it's purely optimization.

For all the boxes checked, include a detailed description of the testing done for the changes made in this pull request.

Additional Information

  • Breaking Changes
  • Deprecations
  • Large PR broken into smaller PRs, and PR plan linked in the description.

For all the boxes checked, include additional details of the changes made in this pull request.

@teamurko teamurko changed the title Make maintenance ops leaner Make snapshots expiration job leaner Jul 5, 2024
Copy link
Collaborator

@maluchari maluchari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change to avoid unnecessary building of validDF !! Should we have a docker run to ensure if commit post this snapshot expiration look as expected?

@teamurko
Copy link
Collaborator Author

teamurko commented Jul 8, 2024

Nice change to avoid unnecessary building of validDF !! Should we have a docker run to ensure if commit post this snapshot expiration look as expected?

It's tested in

public void testSnapshotsExpirationJavaAPI() throws Exception {

@teamurko teamurko requested a review from maluchari July 8, 2024 22:33
@teamurko teamurko merged commit 36aba11 into linkedin:main Jul 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants