Cleanup

linkedin · Jun 25, 2024 · ff7b526 · ff7b526
1 parent 4f7d668
commit ff7b526
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 79 deletions.
diff --git a/libs/datalayout/src/main/java/com/linkedin/openhouse/datalayout/persistence/Utils.java b/libs/datalayout/src/main/java/com/linkedin/openhouse/datalayout/persistence/Utils.java
diff --git a/libs/datalayout/src/test/java/com/linkedin/openhouse/datalayout/e2e/IntegrationTest.java b/libs/datalayout/src/test/java/com/linkedin/openhouse/datalayout/e2e/IntegrationTest.java
@@ -3,7 +3,8 @@
 import com.linkedin.openhouse.datalayout.datasource.TableFileStats;
 import com.linkedin.openhouse.datalayout.layoutselection.DataLayoutOptimizationStrategy;
 import com.linkedin.openhouse.datalayout.layoutselection.OpenHouseDataLayoutGenerator;
-import com.linkedin.openhouse.datalayout.persistence.Utils;
+import com.linkedin.openhouse.datalayout.persistence.StrategiesDao;
+import com.linkedin.openhouse.datalayout.persistence.StrategiesDaoTableProps;
 import com.linkedin.openhouse.tablestest.OpenHouseSparkITest;
 import java.util.List;
 import org.apache.spark.sql.SparkSession;
@@ -25,9 +26,9 @@ public void testCompactionStrategyGenerationWithPersistence() throws Exception {
       Assertions.assertEquals(1, strategies.size());
       Assertions.assertEquals(1, strategies.get(0).getConfig().getPartialProgressMaxCommits());
       Assertions.assertTrue(strategies.get(0).getConfig().isPartialProgressEnabled());
-      Utils.saveStrategies(spark, testTable, strategies);
-      List<DataLayoutOptimizationStrategy> retrievedStrategies =
-          Utils.loadStrategies(spark, testTable);
+      StrategiesDao dao = StrategiesDaoTableProps.builder().spark(spark).build();
+      dao.save(testTable, strategies);
+      List<DataLayoutOptimizationStrategy> retrievedStrategies = dao.load(testTable);
       Assertions.assertEquals(strategies, retrievedStrategies);
     }
   }

diff --git a/libs/datalayout/src/test/java/com/linkedin/openhouse/datalayout/persistence/UtilsTest.java b/libs/datalayout/src/test/java/com/linkedin/openhouse/datalayout/persistence/UtilsTest.java