Skip to content

Commit

Permalink
Fix github build failure (#137)
Browse files Browse the repository at this point in the history
## Summary

The build failed because of missing `khttp` library that is required by
`springdoc-openapi` plugin. This library has been removed from maven2
repo from 2022, so not sure why the previous build succeeded (maybe
github caches some gradle libraries). The `springdoc-openapi` plugin has
removed the usage of `khttp` too since `1.5.0`. I'm upgrading the
version to `1.6.0` which is the latest that gradle 6 supports.

More details in this issue:
springdoc/springdoc-openapi-gradle-plugin#92.

## Changes

- [ ] Client-facing API Changes
- [ ] Internal API Changes
- [x] Bug Fixes
- [ ] New Features
- [ ] Performance Improvements
- [ ] Code Style
- [ ] Refactoring
- [ ] Documentation
- [ ] Tests

For all the boxes checked, please include additional details of the
changes made in this pull request.

## Testing Done
<!--- Check any relevant boxes with "x" -->

- [ ] Manually Tested on local docker setup. Please include commands
ran, and their output.
- [ ] Added new tests for the changes made.
- [ ] Updated existing tests to reflect the changes made.
- [x] No tests added or updated. Please explain why. If unsure, please
feel free to ask for help.
- [ ] Some other form of testing like staging or soak time in
production. Please explain.

For all the boxes checked, include a detailed description of the testing
done for the changes made in this pull request.

# Additional Information

- [ ] Breaking Changes
- [ ] Deprecations
- [ ] Large PR broken into smaller PRs, and PR plan linked in the
description.

For all the boxes checked, include additional details of the changes
made in this pull request.
  • Loading branch information
jiang95-dev committed Jul 17, 2024
1 parent 7ce5645 commit 27a8a07
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion docs/development/client-code-generation.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ To enable a server to produce OpenApi spec, just include the following code bloc
```
plugin {
id 'com.github.johnrengelman.processes' version '0.5.0'
id 'org.springdoc.openapi-gradle-plugin' version '1.3.3'
id 'org.springdoc.openapi-gradle-plugin' version '1.6.0'
id 'openhouse.service-specgen-convention'
}
```
Expand Down
2 changes: 1 addition & 1 deletion services/housetables/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ plugins {
* These are the dependencies to enable client generation for the service.
* */
id 'com.github.johnrengelman.processes' version '0.5.0'
id 'org.springdoc.openapi-gradle-plugin' version '1.3.3'
id 'org.springdoc.openapi-gradle-plugin' version '1.6.0'
id 'openhouse.service-specgen-convention'
}

Expand Down
2 changes: 1 addition & 1 deletion services/jobs/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ plugins {
* These are the dependencies to enable client generation for the service.
* */
id 'com.github.johnrengelman.processes' version '0.5.0'
id 'org.springdoc.openapi-gradle-plugin' version '1.3.3'
id 'org.springdoc.openapi-gradle-plugin' version '1.6.0'
id 'openhouse.service-specgen-convention'
}

Expand Down
2 changes: 1 addition & 1 deletion services/tables/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ plugins {
* These are the dependencies to enable client generation for the service.
* */
id 'com.github.johnrengelman.processes' version '0.5.0'
id 'org.springdoc.openapi-gradle-plugin' version '1.3.3'
id 'org.springdoc.openapi-gradle-plugin' version '1.6.0'
id 'openhouse.service-specgen-convention'
}

Expand Down

0 comments on commit 27a8a07

Please sign in to comment.