[LI-HOTFIX] KAFKA-10012 - Reducing memory overhead associated with strings in MetricName - #83
Merged
Merged
Conversation
navina
changed the title
radai-rosenblatt
approved these changes
May 18, 2020
gitlw
pushed a commit
that referenced
this pull request
Jun 13, 2020
…rings in MetricName (#83) TICKET = LI_DESCRIPTION = SelectorMetrics has a per-connection metrics, which means the number of MetricName objects and the strings associated with it (such as group name and description) grows with the number of connections in the client. This overhead of duplicate string objects is amplified when there are multiple instances of kafka clients within the same JVM. This patch address some of the memory overhead by making metricGrpName a constant and introducing a new constant perConnectionMetricGrpName. Additionally, the strings for metric name and description in createMeter have been interned since there are about 8 types of meter metric for every single client. EXIT_CRITERIA = TICKET [KAFKA-10012]
gitlw
pushed a commit
that referenced
this pull request
Jun 13, 2020
…rings in MetricName (#83) TICKET = LI_DESCRIPTION = SelectorMetrics has a per-connection metrics, which means the number of MetricName objects and the strings associated with it (such as group name and description) grows with the number of connections in the client. This overhead of duplicate string objects is amplified when there are multiple instances of kafka clients within the same JVM. This patch address some of the memory overhead by making metricGrpName a constant and introducing a new constant perConnectionMetricGrpName. Additionally, the strings for metric name and description in createMeter have been interned since there are about 8 types of meter metric for every single client. EXIT_CRITERIA = TICKET [KAFKA-10012]
gitlw
pushed a commit
that referenced
this pull request
Jun 17, 2020
…rings in MetricName (#83) TICKET = LI_DESCRIPTION = SelectorMetrics has a per-connection metrics, which means the number of MetricName objects and the strings associated with it (such as group name and description) grows with the number of connections in the client. This overhead of duplicate string objects is amplified when there are multiple instances of kafka clients within the same JVM. This patch address some of the memory overhead by making metricGrpName a constant and introducing a new constant perConnectionMetricGrpName. Additionally, the strings for metric name and description in createMeter have been interned since there are about 8 types of meter metric for every single client. EXIT_CRITERIA = TICKET [KAFKA-10012]
gitlw
pushed a commit
that referenced
this pull request
Jun 17, 2020
…rings in MetricName (#83) TICKET = LI_DESCRIPTION = SelectorMetrics has a per-connection metrics, which means the number of MetricName objects and the strings associated with it (such as group name and description) grows with the number of connections in the client. This overhead of duplicate string objects is amplified when there are multiple instances of kafka clients within the same JVM. This patch address some of the memory overhead by making metricGrpName a constant and introducing a new constant perConnectionMetricGrpName. Additionally, the strings for metric name and description in createMeter have been interned since there are about 8 types of meter metric for every single client. EXIT_CRITERIA = TICKET [KAFKA-10012]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TICKET =
LI_DESCRIPTION =
SelectorMetricshas a per-connection metrics, which means the number ofMetricNameobjects and the strings associated with it (such as group name and description) grows with the number of connections in the client. This overhead of duplicate string objects is amplified when there are multiple instances of kafka clients within the same JVM. This patch address some of the memory overhead by makingmetricGrpNamea constant and introducing a new constantperConnectionMetricGrpName. Additionally, the strings for metric name and description increateMeterhave been interned since there are about 8 types of meter metric for every single client.EXIT_CRITERIA = TICKET [KAFKA-10012]