[LI-HOTFIX] fix DynamicConfig and DynamicBrokerConfig cross reference… - #69
Merged
Conversation
… issue TICKET = LI_DESCRIPTION = DynamicBrokerConfig holds a reference to DynamicConfig.Broker.ClusterLevelConfigs. During DynamicConfig object initialization, DynamicBrokerConfig object is created if it was not created before. kafka-configs.sh script (ConfigCommand.scala) tries to create DynamicConfig object directly, which in turns creates DynamicBrokerConfig object. This fix makes sure that when initializing DynamicBrokerConfig object, DynamicConfig.Broker.ClusterLevelConfigs should have already been defined. EXIT_CRITERIA = MANUAL [""]
gitlw
pushed a commit
that referenced
this pull request
Jun 1, 2020
… issue (#69) TICKET = LI_DESCRIPTION = DynamicBrokerConfig holds a reference to DynamicConfig.Broker.ClusterLevelConfigs. During DynamicConfig object initialization, DynamicBrokerConfig object is created if it was not created before. kafka-configs.sh script (ConfigCommand.scala) tries to create DynamicConfig object directly, which in turns creates DynamicBrokerConfig object. This fix makes sure that when initializing DynamicBrokerConfig object, DynamicConfig.Broker.ClusterLevelConfigs should have already been defined. EXIT_CRITERIA = MANUAL [""]
gitlw
pushed a commit
that referenced
this pull request
Jun 12, 2020
… issue (#69) TICKET = LI_DESCRIPTION = DynamicBrokerConfig holds a reference to DynamicConfig.Broker.ClusterLevelConfigs. During DynamicConfig object initialization, DynamicBrokerConfig object is created if it was not created before. kafka-configs.sh script (ConfigCommand.scala) tries to create DynamicConfig object directly, which in turns creates DynamicBrokerConfig object. This fix makes sure that when initializing DynamicBrokerConfig object, DynamicConfig.Broker.ClusterLevelConfigs should have already been defined. EXIT_CRITERIA = MANUAL [""]
gitlw
pushed a commit
that referenced
this pull request
Jun 13, 2020
… issue (#69) TICKET = LI_DESCRIPTION = DynamicBrokerConfig holds a reference to DynamicConfig.Broker.ClusterLevelConfigs. During DynamicConfig object initialization, DynamicBrokerConfig object is created if it was not created before. kafka-configs.sh script (ConfigCommand.scala) tries to create DynamicConfig object directly, which in turns creates DynamicBrokerConfig object. This fix makes sure that when initializing DynamicBrokerConfig object, DynamicConfig.Broker.ClusterLevelConfigs should have already been defined. EXIT_CRITERIA = MANUAL [""]
lmr3796
pushed a commit
to lmr3796/kafka
that referenced
this pull request
Jan 18, 2022
This also squashes the directly related test commits - e59b0da [LI-HOTFIX] Add test case for describe maintenance broker config (linkedin#248) - 1f7bab6 [LI-HOTFIX] fix DynamicConfig and DynamicBrokerConfig cross reference issue (linkedin#69) TICKET = KAFKA-8527 LI_DESCRIPTION = When a broker is masked as maintenance broker, Kafka will not assign partitions of new topics to the broker if partition assignment is done by kafka brokers. 1) add dynamic broker config to support maintenance brokers 2) add logic to update maintenance broker info in controller 3) support maintenance broker in Kafka API 4) support maintenance broker in AdminZkClient 5) add logic to rearrange replica assignment for new topics for maintenance brokers 5) test cases RB=1484649 G=Kafka-Code-Reviews R=agencer, amendhek, jkoshy, zahuang A=zahuang EXIT_CRITERIA = TICKET [KAFKA-8527]
lmr3796
pushed a commit
to lmr3796/kafka
that referenced
this pull request
Feb 9, 2022
This also squashes the directly related test commits - e59b0da [LI-HOTFIX] Add test case for describe maintenance broker config (linkedin#248) - 1f7bab6 [LI-HOTFIX] fix DynamicConfig and DynamicBrokerConfig cross reference issue (linkedin#69) TICKET = KAFKA-8527 LI_DESCRIPTION = When a broker is masked as maintenance broker, Kafka will not assign partitions of new topics to the broker if partition assignment is done by kafka brokers. 1) add dynamic broker config to support maintenance brokers 2) add logic to update maintenance broker info in controller 3) support maintenance broker in Kafka API 4) support maintenance broker in AdminZkClient 5) add logic to rearrange replica assignment for new topics for maintenance brokers 5) test cases RB=1484649 G=Kafka-Code-Reviews R=agencer, amendhek, jkoshy, zahuang A=zahuang EXIT_CRITERIA = TICKET [KAFKA-8527]
lmr3796
pushed a commit
to lmr3796/kafka
that referenced
this pull request
Mar 25, 2022
This also squashes the directly related test commits - e59b0da [LI-HOTFIX] Add test case for describe maintenance broker config (linkedin#248) - 1f7bab6 [LI-HOTFIX] fix DynamicConfig and DynamicBrokerConfig cross reference issue (linkedin#69) TICKET = KAFKA-8527 LI_DESCRIPTION = When a broker is masked as maintenance broker, Kafka will not assign partitions of new topics to the broker if partition assignment is done by kafka brokers. 1) add dynamic broker config to support maintenance brokers 2) add logic to update maintenance broker info in controller 3) support maintenance broker in Kafka API 4) support maintenance broker in AdminZkClient 5) add logic to rearrange replica assignment for new topics for maintenance brokers 5) test cases RB=1484649 G=Kafka-Code-Reviews R=agencer, amendhek, jkoshy, zahuang A=zahuang EXIT_CRITERIA = TICKET [KAFKA-8527]
lmr3796
pushed a commit
to lmr3796/kafka
that referenced
this pull request
Jun 2, 2022
This also squashes the directly related test commits - e59b0da [LI-HOTFIX] Add test case for describe maintenance broker config (linkedin#248) - 1f7bab6 [LI-HOTFIX] fix DynamicConfig and DynamicBrokerConfig cross reference issue (linkedin#69) TICKET = KAFKA-8527 LI_DESCRIPTION = When a broker is masked as maintenance broker, Kafka will not assign partitions of new topics to the broker if partition assignment is done by kafka brokers. 1) add dynamic broker config to support maintenance brokers 2) add logic to update maintenance broker info in controller 3) support maintenance broker in Kafka API 4) support maintenance broker in AdminZkClient 5) add logic to rearrange replica assignment for new topics for maintenance brokers 5) test cases RB=1484649 G=Kafka-Code-Reviews R=agencer, amendhek, jkoshy, zahuang A=zahuang EXIT_CRITERIA = TICKET [KAFKA-8527]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… issue
TICKET =
LI_DESCRIPTION =
DynamicBrokerConfig holds a reference to DynamicConfig.Broker.ClusterLevelConfigs.
During DynamicConfig object initialization, DynamicBrokerConfig object is created if it was not created before.
kafka-configs.sh script (ConfigCommand.scala) tries to create DynamicConfig object directly, which in turns creates DynamicBrokerConfig object.
This fix makes sure that
when initializing DynamicBrokerConfig object, DynamicConfig.Broker.ClusterLevelConfigs should have already been defined.
EXIT_CRITERIA = MANUAL [""]