Skip to content

[LI-HOTFIX] Guard costly trace- and debug-level logging to avoid unnecessary resource use during index operations. - #64

Merged
efeg merged 2 commits into
linkedin:2.3-lifrom
efeg:fix/guardLogs
Dec 19, 2019
Merged

[LI-HOTFIX] Guard costly trace- and debug-level logging to avoid unnecessary resource use during index operations.#64
efeg merged 2 commits into
linkedin:2.3-lifrom
efeg:fix/guardLogs

Conversation

@efeg

@efeg efeg commented Dec 18, 2019

Copy link
Copy Markdown

TICKET =
LI_DESCRIPTION = PR apache#6385 has added several debug and trace statements in AbstractIndex.scala, OffsetIndex.scala, and TimeIndex.scala. However, not guarding these logging statements yields redundant waste of resources during index operations. This patch adds log guarding to avoid this resource waste.

EXIT_CRITERIA = MANUAL [""]

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

…cessary resource use during index operations.

TICKET =
LI_DESCRIPTION =

EXIT_CRITERIA = MANUAL [""]
@efeg
efeg requested a review from xiowu0 December 18, 2019 00:34

@xiowu0 xiowu0 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment thread core/src/test/scala/unit/kafka/log/TimeIndexTest.scala Outdated
Comment thread core/src/main/scala/kafka/log/TimeIndex.scala
@efeg
efeg merged commit f5a78f4 into linkedin:2.3-li Dec 19, 2019
@efeg
efeg deleted the fix/guardLogs branch December 19, 2019 23:04
gitlw pushed a commit that referenced this pull request May 30, 2020
…cessary resource use during index operations. (#64)

TICKET =
LI_DESCRIPTION = PR apache#6385 has added several debug and trace statements in AbstractIndex.scala, OffsetIndex.scala, and TimeIndex.scala. However, not guarding these logging statements yields waste of resources during index operations. This patch adds log guarding to avoid this resource waste.
EXIT_CRITERIA = MANUAL [""]
gitlw pushed a commit that referenced this pull request Jun 12, 2020
…cessary resource use during index operations. (#64)

TICKET =
LI_DESCRIPTION = PR apache#6385 has added several debug and trace statements in AbstractIndex.scala, OffsetIndex.scala, and TimeIndex.scala. However, not guarding these logging statements yields waste of resources during index operations. This patch adds log guarding to avoid this resource waste.
EXIT_CRITERIA = MANUAL [""]
gitlw pushed a commit that referenced this pull request Jun 13, 2020
…cessary resource use during index operations. (#64)

TICKET =
LI_DESCRIPTION = PR apache#6385 has added several debug and trace statements in AbstractIndex.scala, OffsetIndex.scala, and TimeIndex.scala. However, not guarding these logging statements yields waste of resources during index operations. This patch adds log guarding to avoid this resource waste.
EXIT_CRITERIA = MANUAL [""]
lmr3796 pushed a commit to lmr3796/kafka that referenced this pull request Feb 9, 2022
…cessary resource use during index operations (linkedin#64)

TICKET =
LI_DESCRIPTION = PR apache#6385 has added several debug and trace statements in AbstractIndex.scala, OffsetIndex.scala, and TimeIndex.scala. However, not guarding these logging statements yields waste of resources during index operations. This patch adds log guarding to avoid this resource waste.
EXIT_CRITERIA = MANUAL [""]
lmr3796 pushed a commit to lmr3796/kafka that referenced this pull request Feb 9, 2022
…cessary resource use during index operations (linkedin#64)

TICKET =
LI_DESCRIPTION = PR apache#6385 has added several debug and trace statements in AbstractIndex.scala, OffsetIndex.scala, and TimeIndex.scala. However, not guarding these logging statements yields waste of resources during index operations. This patch adds log guarding to avoid this resource waste.
EXIT_CRITERIA = MANUAL [""]
lmr3796 pushed a commit to lmr3796/kafka that referenced this pull request Mar 25, 2022
…cessary resource use during index operations (linkedin#64)

TICKET =
LI_DESCRIPTION = PR apache#6385 has added several debug and trace statements in AbstractIndex.scala, OffsetIndex.scala, and TimeIndex.scala. However, not guarding these logging statements yields waste of resources during index operations. This patch adds log guarding to avoid this resource waste.
EXIT_CRITERIA = MANUAL [""]
lmr3796 pushed a commit to lmr3796/kafka that referenced this pull request Jun 2, 2022
…cessary resource use during index operations (linkedin#64)

TICKET =
LI_DESCRIPTION = PR apache#6385 has added several debug and trace statements in AbstractIndex.scala, OffsetIndex.scala, and TimeIndex.scala. However, not guarding these logging statements yields waste of resources during index operations. This patch adds log guarding to avoid this resource waste.
EXIT_CRITERIA = MANUAL [""]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants