Fix the bug which make SSL channel raise false buffer overflow alert. - #62
Merged
Conversation
wyuka
added a commit
that referenced
this pull request
Mar 10, 2022
* [LI-HOTFIX] Add support to use BoringSSL for SSL/TLS. TICKET = KAFKA-2561 LI_DESCRIPTION = Make Kafka capable of using BoringSSL for encryption. EXIT_CRITERIA = TICKET [KAFKA-2561] * Removed unused imports * [LI-HOTFIX] Fix SSL channel close on fake buffer overflow/underflow (#62) TICKET = LI_DESCRIPTION = SslTransportLayer takes netBuffer/appBuffer full as buffer overflow and close the connection unnecessarily. EXIT_CRITERIA = MANUAL [""] * Fix failing unit tests. Co-authored-by: kun du <kdu@linkedin.com>
lmr3796
pushed a commit
to lmr3796/kafka
that referenced
this pull request
Mar 25, 2022
Cherry picked commit: * [LI-HOTFIX] Add support to use BoringSSL for SSL/TLS. TICKET = KAFKA-2561 LI_DESCRIPTION = Make Kafka capable of using BoringSSL for encryption. EXIT_CRITERIA = TICKET [KAFKA-2561] * Removed unused imports * [LI-HOTFIX] Fix SSL channel close on fake buffer overflow/underflow (linkedin#62) TICKET = LI_DESCRIPTION = SslTransportLayer takes netBuffer/appBuffer full as buffer overflow and close the connection unnecessarily. EXIT_CRITERIA = MANUAL [""] * Fix failing unit tests. Co-authored-by: kun du <kdu@linkedin.com>
lmr3796
pushed a commit
to lmr3796/kafka
that referenced
this pull request
Jun 2, 2022
Cherry picked commit: * [LI-HOTFIX] Add support to use BoringSSL for SSL/TLS. TICKET = KAFKA-2561 LI_DESCRIPTION = Make Kafka capable of using BoringSSL for encryption. EXIT_CRITERIA = TICKET [KAFKA-2561] * Removed unused imports * [LI-HOTFIX] Fix SSL channel close on fake buffer overflow/underflow (linkedin#62) TICKET = LI_DESCRIPTION = SslTransportLayer takes netBuffer/appBuffer full as buffer overflow and close the connection unnecessarily. EXIT_CRITERIA = MANUAL [""] * Fix failing unit tests. Co-authored-by: kun du <kdu@linkedin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observed following exception in broker logs
This is from Kafka's
SslTransportLayer's handling logic ofBUFFER_OVERFLOWreturned fromSslEnigne.unwrap(), which potentially expand the buffer size and then checkbuffer.position()is less than
buffer.capacity(), otherwise throws an Exception.The sanity check here checks is too strict since the invariant Buffer provides is
So position == capacity just means the buffer is full not overflow.