Conversation
…ducer clientId to ProducerConfig when users haven't provided one.
| InetAddress[] addresses = InetAddress.getAllByName(host); | ||
| log.debug("Resolved {} and got addresses: ", host); | ||
| for (InetAddress address: addresses) { | ||
| log.debug(address.getHostAddress() + ";"); |
There was a problem hiding this comment.
this getHostAddress prints the actual resolved host name, not the bootstrap dns disco address, right?
There was a problem hiding this comment.
getHostAddress returns the IP address string in textual presentation.
| this.clientId = buildClientId(configuredClientId, transactionalId); | ||
|
|
||
| if (configuredClientId.isEmpty()) { | ||
| config.originals().put(ProducerConfig.CLIENT_ID_CONFIG, this.clientId); |
There was a problem hiding this comment.
what's the usage for this? If user didn't supply a client.id, the printed configs will have client.id as empty field?
There was a problem hiding this comment.
yes, when users didn't config client.id, kafka clients will self generate it and the ProducerConfig values result will be: client.id =
| @@ -111,6 +111,10 @@ public static ChannelBuilder createChannelBuilder(AbstractConfig config, Time ti | |||
|
|
|||
There was a problem hiding this comment.
nit: you'll need to follow the pr format for kafka repos, similar to #329
There was a problem hiding this comment.
Thanks, modified the format. Lemme know if further adjustment is needed.
fluffywei
changed the title
2 participants
Added debugger to print resolved IPs; assigned the self generated producer clientId to ProducerConfig when users haven't provided one.
EXIT_CRITERIA = When gets to the root of how the client’s DNS resolver gets it’s IPs in a kafka clients test in EI cluster
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)