[LI-CHERRY-PICK] use_all_dns_ips as default value for client.dns.lookup - #348
Merged
Conversation
fluffywei
approved these changes
Jun 3, 2022
ZIDAZ
pushed a commit
that referenced
this pull request
Jun 3, 2022
ZIDAZ
pushed a commit
that referenced
this pull request
Jun 6, 2022
3 tasks
ZIDAZ
pushed a commit
that referenced
this pull request
Jun 6, 2022
* [LI-HOTFIX] Do not resolve bootstrap server during client bootstrap/startup (#315) * do not resolve bootstrap server during client bootstrap/startup Co-authored-by: Ke Hu <kehu@kehu-mn2.linkedin.biz> * [LI-HOTFIX] use_all_dns_ips as default value for client.dns.lookup (#348) * [LI-HOTFIX] log level change to avoid flooding the logs * [LI-HOTFIX] Ignore the failed test ClusterConnectionStatesTest#testMultipleIPsWithUseAll (#116) TICKET = N/A LI_DESCRIPTION = The test fails since the domain kafka.apache.org used to return 3 IPs and is now only returning two IPs. Furthermore, the upstream fix identified below cannot be cleanly cherry picked. EXIT_CRITERIA = when the commit 131d475 is picked from upstream: KAFKA-12193: Re-resolve IPs after a client disconnects apache#9902 * [LI-HOTFIX] Ignoring the failed tests (#188) TICKET = N/A LI_DESCRIPTION = Several tests are failing since the domain kafka.apache.org that used to resolve to more than 1 IPv4 addresses are not only resolving to 1 IPv4 address. The upstream code has overhauled the ClusterConnectionStatesTest. We are simply ignoring these tests for now, and will get the new logic from upstream after a major version rebase. EXIT_CRITERIA = This hotfix can be removed in the next major version rebase Co-authored-by: Ke Hu <kehu@linkedin.com> Co-authored-by: Ke Hu <kehu@kehu-mn2.linkedin.biz> Co-authored-by: Lucas Wang <luwang@linkedin.com>
ZIDAZ
changed the title
ZIDAZ
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to reduce connection failure rates by using all the possible IP addresses of a hostname instead of just using the first one, change the default value of client.dns.lookup configuration in AdminClientConfig, ProducerConfig and ConsumerConfig, as well as server, tool and test code from "default" to "use_all_dns_ips".
To achieve the old behavior of using the first resolved IP, explicitly set the value of client.dns.lookup configuration to "default".
Backport the change from KIP-602 apache#8644, which is already used in 3.0-li
Committer Checklist (excluded from commit message)