[LI-FIXUP] Bypass cluster metadata auto refresh code path by default - #330
Merged
Conversation
This should be a fix up to linkedin#316 The PR linkedin#228 attempted to resolve provided boostrap servers when the metadata is exceeding a staleness threshold. The config is coverred both on producer and consumer, and default behavior without configured value is setting timeout to Long.MAX_VALUE. However, cruise-control is affected by the behavior as it implements a similar mechanism on its own and directly uses of NetworkClient. The code would fail if empty bootstrap server is passed to NetworkClient, which is the case for internal use of CC. To resolve this, this patch aims to make default value as -1, and omit the code path referencing bootstrap server when we see -1. EXIT_CRITERIA = When linkedin#316 is ejected
3 tasks
kehuum
approved these changes
Apr 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be a fix-up to #316, and the same patch is also made to the 2.4 branch in #329.
The PR #228 attempted to resolve provided bootstrap servers when
the metadata is exceeding a staleness threshold. The config is covered
both on producer and consumer, and default behavior without configured
value is setting the timeout to
Long.MAX_VALUE.However,
cruise-controlis affected by the behavior as it implements asimilar mechanism on its own and directly uses
NetworkClient. The codewould fail if an empty bootstrap server list is passed to
NetworkClient, whichis the case for internal use of CC.
To resolve this, this patch aims to make the default value -1, and omit
the code path referencing bootstrap server when we see -1.
EXIT_CRITERIA = When #316 is ejected
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)