Skip to content

[LI-HOTFIX] Fix flakiness in ControllerIntegrationTest#testRollingControlledShutdown - #230

Merged
lmr3796 merged 1 commit into
linkedin:2.4-lifrom
lmr3796:fix-test-rolling-controller-bounce2
Dec 22, 2021
Merged

[LI-HOTFIX] Fix flakiness in ControllerIntegrationTest#testRollingControlledShutdown#230
lmr3796 merged 1 commit into
linkedin:2.4-lifrom
lmr3796:fix-test-rolling-controller-bounce2

Conversation

@lmr3796

@lmr3796 lmr3796 commented Dec 22, 2021

Copy link
Copy Markdown

This test is introduced in #187

In the test, it verifies through getPartitionInfo(topic,partition).get.isr.size.
However, the partition info may not be ready yet and the .get may throw
exception occasionally.

TICKET = N/A
EXIT_CRITERIA = N/A

@lmr3796

lmr3796 commented Dec 22, 2021

Copy link
Copy Markdown
Author

The test belongs to intTest/core (A B C)

@lmr3796
lmr3796 requested a review from gitlw December 22, 2021 21:29
Comment thread core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala Outdated
Comment thread core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala Outdated
@lmr3796
lmr3796 force-pushed the fix-test-rolling-controller-bounce2 branch from f416721 to 585493d Compare December 22, 2021 22:07
Comment thread core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala Outdated
Comment thread core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala Outdated
…trolledShutdown

In the test, it verifies through `getPartitionInfo(topic,partition).get.isr.size`.
However, the partition info may not be ready yet and the .get may throw
exception occasionally.

TICKET = N/A
EXIT_CRITERIA = N/A
@lmr3796
lmr3796 force-pushed the fix-test-rolling-controller-bounce2 branch from 585493d to 23df77b Compare December 22, 2021 22:15

@gitlw gitlw left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@lmr3796
lmr3796 merged commit 82077ed into linkedin:2.4-li Dec 22, 2021
@lmr3796
lmr3796 deleted the fix-test-rolling-controller-bounce2 branch December 22, 2021 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants