fix in parallel topic deletion and partition reassignment issue - #14
Merged
Conversation
jjkoshy
reviewed
Apr 18, 2019
There was a problem hiding this comment.
Is this check necessary for this test?
Instead, could you just assertTrue(waitForReassignmentToComplete(0)) at the end?
Author
There was a problem hiding this comment.
changed to waitForReassignmentToComplete(). This is a void function check for partition reassignment znode, and also use default pause-time waitForReassignmentToComplete(pause: Long = 100L)
hzxa21
reviewed
Apr 18, 2019
kafka allows topic deletion to complete successfully when there are pending partition reassignments of the same topics. This leads several issues: 1) pending partition reassignment of the deleted topic never complete because the topic is deleted. 2) onPartitionReassignment -> updateAssignedReplicasForPartition will throw out IllegalStateException for non-existing node. This in turns causes controller doesn't resume topic deletion for online broker and register broker notification handler (etc.) during onBrokerStartup. The fix cleans up pending partition reassignment during topic deletion.
xiowu0
force-pushed
the
reassign_deletion
branch
from
April 19, 2019 18:24
98fb5de to
3fb2a8f
Compare
jjkoshy
approved these changes
Apr 24, 2019
xiowu0
added a commit
that referenced
this pull request
Jun 11, 2019
… issue (#14) TICKET = KAFKA-8249 LI_DESCRIPTION = kafka allows topic deletion to complete successfully when there are pending partition reassignments of the same topics. This leads several issues: 1) pending partition reassignment of the deleted topic never complete because the topic is deleted. 2) onPartitionReassignment -> updateAssignedReplicasForPartition will throw out IllegalStateException for non-existing node. This in turns causes controller doesn't resume topic deletion for online broker and register broker notification handler (etc.) during onBrokerStartup. The fix cleans up pending partition reassignment during topic deletion. EXIT_CRITERIA = TICKET [KAFKA-8249]
xiowu0
added a commit
that referenced
this pull request
Jul 17, 2019
TICKET = KAFKA-8249 LI_DESCRIPTION = kafka allows topic deletion to complete successfully when there are pending partition reassignments of the same topics. This leads several issues: 1) pending partition reassignment of the deleted topic never complete because the topic is deleted. 2) onPartitionReassignment -> updateAssignedReplicasForPartition will throw out IllegalStateException for non-existing node. This in turns causes controller doesn't resume topic deletion for online broker and register broker notification handler (etc.) during onBrokerStartup. The fix cleans up pending partition reassignment during topic deletion. EXIT_CRITERIA = TICKET [KAFKA-8249]
xiowu0
added a commit
that referenced
this pull request
Aug 22, 2019
TICKET = KAFKA-8249 LI_DESCRIPTION = kafka allows topic deletion to complete successfully when there are pending partition reassignments of the same topics. This leads several issues: 1) pending partition reassignment of the deleted topic never comes to completion after topic is deleted. 2) onPartitionReassignment -> updateAssignedReplicasForPartition will throw out IllegalStateException for non-existing node. This in turns causes controller not to resume topic deletion for online broker and not to register broker notification handler during onBrokerStartup. The fix cleans up pending partition reassignment during topic deletion. EXIT_CRITERIA = TICKET [KAFKA-8249]
xiowu0
added a commit
that referenced
this pull request
May 29, 2020
TICKET = KAFKA-8249 LI_DESCRIPTION = kafka allows topic deletion to complete successfully when there are pending partition reassignments of the same topics. This leads several issues: 1) pending partition reassignment of the deleted topic never comes to completion after topic is deleted. 2) onPartitionReassignment -> updateAssignedReplicasForPartition will throw out IllegalStateException for non-existing node. This in turns causes controller not to resume topic deletion for online broker and not to register broker notification handler during onBrokerStartup. The fix cleans up pending partition reassignment during topic deletion. EXIT_CRITERIA = TICKET [KAFKA-8249]
gitlw
pushed a commit
that referenced
this pull request
Jun 12, 2020
TICKET = KAFKA-8249 LI_DESCRIPTION = kafka allows topic deletion to complete successfully when there are pending partition reassignments of the same topics. This leads several issues: 1) pending partition reassignment of the deleted topic never comes to completion after topic is deleted. 2) onPartitionReassignment -> updateAssignedReplicasForPartition will throw out IllegalStateException for non-existing node. This in turns causes controller not to resume topic deletion for online broker and not to register broker notification handler during onBrokerStartup. The fix cleans up pending partition reassignment during topic deletion. EXIT_CRITERIA = TICKET [KAFKA-8249]
gitlw
pushed a commit
that referenced
this pull request
Jun 13, 2020
TICKET = KAFKA-8249 LI_DESCRIPTION = kafka allows topic deletion to complete successfully when there are pending partition reassignments of the same topics. This leads several issues: 1) pending partition reassignment of the deleted topic never comes to completion after topic is deleted. 2) onPartitionReassignment -> updateAssignedReplicasForPartition will throw out IllegalStateException for non-existing node. This in turns causes controller not to resume topic deletion for online broker and not to register broker notification handler during onBrokerStartup. The fix cleans up pending partition reassignment during topic deletion. EXIT_CRITERIA = TICKET [KAFKA-8249]
lmr3796
pushed a commit
that referenced
this pull request
Feb 9, 2022
TICKET = KAFKA-8249 LI_DESCRIPTION = kafka allows topic deletion to complete successfully when there are pending partition reassignments of the same topics. This leads several issues: 1) pending partition reassignment of the deleted topic never comes to completion after topic is deleted. 2) onPartitionReassignment -> updateAssignedReplicasForPartition will throw out IllegalStateException for non-existing node. This in turns causes controller not to resume topic deletion for online broker and not to register broker notification handler during onBrokerStartup. The fix cleans up pending partition reassignment during topic deletion. EXIT_CRITERIA = TICKET [KAFKA-8249]
lmr3796
pushed a commit
that referenced
this pull request
Feb 9, 2022
TICKET = KAFKA-8249 LI_DESCRIPTION = kafka allows topic deletion to complete successfully when there are pending partition reassignments of the same topics. This leads several issues: 1) pending partition reassignment of the deleted topic never comes to completion after topic is deleted. 2) onPartitionReassignment -> updateAssignedReplicasForPartition will throw out IllegalStateException for non-existing node. This in turns causes controller not to resume topic deletion for online broker and not to register broker notification handler during onBrokerStartup. The fix cleans up pending partition reassignment during topic deletion. EXIT_CRITERIA = TICKET [KAFKA-8249]
lmr3796
pushed a commit
that referenced
this pull request
Mar 25, 2022
TICKET = KAFKA-8249 LI_DESCRIPTION = kafka allows topic deletion to complete successfully when there are pending partition reassignments of the same topics. This leads several issues: 1) pending partition reassignment of the deleted topic never comes to completion after topic is deleted. 2) onPartitionReassignment -> updateAssignedReplicasForPartition will throw out IllegalStateException for non-existing node. This in turns causes controller not to resume topic deletion for online broker and not to register broker notification handler during onBrokerStartup. The fix cleans up pending partition reassignment during topic deletion. EXIT_CRITERIA = TICKET [KAFKA-8249]
lmr3796
pushed a commit
that referenced
this pull request
Jun 2, 2022
TICKET = KAFKA-8249 LI_DESCRIPTION = kafka allows topic deletion to complete successfully when there are pending partition reassignments of the same topics. This leads several issues: 1) pending partition reassignment of the deleted topic never comes to completion after topic is deleted. 2) onPartitionReassignment -> updateAssignedReplicasForPartition will throw out IllegalStateException for non-existing node. This in turns causes controller not to resume topic deletion for online broker and not to register broker notification handler during onBrokerStartup. The fix cleans up pending partition reassignment during topic deletion. EXIT_CRITERIA = TICKET [KAFKA-8249]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kafka allows topic deletion to complete successfully when there are pending partition reassignments of the same topics. This leads several issues: 1) pending partition reassignments of the deleted topic never complete because the topic is deleted. 2) onPartitionReassignment -> updateAssignedReplicasForPartition will throw out IllegalStateException for non-existing node. This in turns causes controller doesn't resume topic deletion for online broker and register broker notification handler (etc.) during onBrokerStartup.
The fix cleans up pending partition reassignment during topic deletion.