Skip to content

[LI-HOTFIX] Add a Github Actions workflow to trigger build and run all tests upon a tag creation/push - #107

Merged
Lincong merged 5 commits into
linkedin:2.4-lifrom
Lincong:build-and-upload-jar-upon-creating-tag-github-action
Jan 5, 2021
Merged

[LI-HOTFIX] Add a Github Actions workflow to trigger build and run all tests upon a tag creation/push#107
Lincong merged 5 commits into
linkedin:2.4-lifrom
Lincong:build-and-upload-jar-upon-creating-tag-github-action

Conversation

@Lincong

@Lincong Lincong commented Jan 5, 2021

Copy link
Copy Markdown

Add a Github Actions workflow to trigger build and run all tests upon a tag creation/push

TICKET = N/A
LI_DESCRIPTION = LIKAFKA-34202
EXIT_CRITERIA = N/A

@Lincong

Lincong commented Jan 5, 2021

Copy link
Copy Markdown
Author

Note that this change does not actually upload the archive since there are several things to verify before we enable the feature to upload the archive. Please see comments in the TODO section at the bottom of the added yml file. Thanks!

@Lincong
Lincong requested review from gitlw and yifangl January 5, 2021 17:05
gitlw
gitlw reviewed Jan 5, 2021
View reviewed changes
Comment thread .github/workflows/build-and-upload-archives-upon-creating-tags.yml
gitlw
gitlw reviewed Jan 5, 2021
View reviewed changes
Comment thread .github/workflows/build-and-upload-archives-upon-creating-tags.yml Outdated
gitlw
gitlw approved these changes Jan 5, 2021
View reviewed changes

@gitlw gitlw left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Lincong
Lincong merged commit bb6cab9 into linkedin:2.4-li Jan 5, 2021
@Lincong
Lincong deleted the build-and-upload-jar-upon-creating-tag-github-action branch January 5, 2021 17:56
lmr3796 pushed a commit that referenced this pull request Oct 6, 2021
@Lincong @lmr3796
[LI-HOTFIX] Migrate CI build to Github Actions
3a9cadc 
This commit is a squash of:
- [LI-HOTFIX] Add a Github Actions workflow to trigger build and test upon PR and push (#106)
- [LI-HOTFIX] Add a Github Actions workflow to trigger build and run all tests upon a tag creation/push (#107)
- [LI-HOTFIX] Enable the Github Actions workflow to upload the built archive and disable all Travis actions (#108)
- [LI-HOTFIX] Updating description of the CI flow (#114)

TICKET = N/A
LI_DESCRIPTION = LIKAFKA-34202
EXIT_CRITERIA = N/A
lmr3796 pushed a commit to lmr3796/kafka that referenced this pull request Oct 22, 2021
@Lincong @lmr3796
[LI-HOTFIX] CI: Migrate CI build to Github Actions
04d0d8d 
This commit is a squash of:
- [LI-HOTFIX] Add a Github Actions workflow to trigger build and test upon PR and push (linkedin#106)
- [LI-HOTFIX] Add a Github Actions workflow to trigger build and run all tests upon a tag creation/push (linkedin#107)
- [LI-HOTFIX] Enable the Github Actions workflow to upload the built archive and disable all Travis actions (linkedin#108)
- [LI-HOTFIX] Updating description of the CI flow (linkedin#114)
- Add rat to CI build to make it consistent with PR (linkedin#173)

And partially picked up the rat set up from
- Adding licence and rat check (linkedin#159)

TICKET = N/A
LI_DESCRIPTION = LIKAFKA-34202
EXIT_CRITERIA = When migrating off Github Actions for CI

[LI-HOTFIX] Add rat to CI build to make it consistent with PR (linkedin#173)
lmr3796 pushed a commit to lmr3796/kafka that referenced this pull request Oct 22, 2021
@Lincong @lmr3796
[LI-HOTFIX] CI: Migrate CI build to Github Actions
2b3ab52 
This commit is a squash of:
- [LI-HOTFIX] Add a Github Actions workflow to trigger build and test upon PR and push (linkedin#106)
- [LI-HOTFIX] Add a Github Actions workflow to trigger build and run all tests upon a tag creation/push (linkedin#107)
- [LI-HOTFIX] Enable the Github Actions workflow to upload the built archive and disable all Travis actions (linkedin#108)
- [LI-HOTFIX] Updating description of the CI flow (linkedin#114)
- Add rat to CI build to make it consistent with PR (linkedin#173)

And partially picked up the rat set up from
- Adding licence and rat check (linkedin#159)

TICKET = N/A
LI_DESCRIPTION = LIKAFKA-34202
EXIT_CRITERIA = When migrating off Github Actions for CI

[LI-HOTFIX] Add rat to CI build to make it consistent with PR (linkedin#173)
lmr3796 pushed a commit to lmr3796/kafka that referenced this pull request Oct 22, 2021
@Lincong @lmr3796
[LI-HOTFIX] CI: Migrate CI build to Github Actions
86b41b2 
This commit is a squash of:
- [LI-HOTFIX] Add a Github Actions workflow to trigger build and test upon PR and push (linkedin#106)
- [LI-HOTFIX] Add a Github Actions workflow to trigger build and run all tests upon a tag creation/push (linkedin#107)
- [LI-HOTFIX] Enable the Github Actions workflow to upload the built archive and disable all Travis actions (linkedin#108)
- [LI-HOTFIX] Updating description of the CI flow (linkedin#114)
- Add rat to CI build to make it consistent with PR (linkedin#173)

And partially picked up the rat set up from
- Adding licence and rat check (linkedin#159)

TICKET = N/A
LI_DESCRIPTION = LIKAFKA-34202
EXIT_CRITERIA = When migrating off Github Actions for CI

[LI-HOTFIX] Add rat to CI build to make it consistent with PR (linkedin#173)
lmr3796 pushed a commit that referenced this pull request Oct 27, 2021
@Lincong @lmr3796
[LI-HOTFIX] CI: Migrate CI build to Github Actions
7b8c9f5 
This commit is a squash of:
- 97f6a93 [LI-HOTFIX] Add a Github Actions workflow to trigger build and test upon PR and push (#106)
- bb6cab9 [LI-HOTFIX] Add a Github Actions workflow to trigger build and run all tests upon a tag creation/push (#107)
- 4ac92ac [LI-HOTFIX] Enable the Github Actions workflow to upload the built archive and disable all Travis actions (#108)
- 883ece3 [LI-HOTFIX] Updating description of the CI flow (#114)
- 77cad71 [LI-HOTFIX] Add rat to CI build to make it consistent with PR (#173)
- 2af73a1 [LI-HOTFIX] CI: Split test builds to multiple jobs
- 22517e6 [LI-HOTFIX] CI: Enable spotbugs on build (#195)

And partially picked up the rat set up from
- 66596f0 [LI-HOTFIX] Adding licence and rat check (#159)

TICKET = N/A
LI_DESCRIPTION = LIKAFKA-34202
EXIT_CRITERIA = When migrating off Github Actions for CI
lmr3796 pushed a commit that referenced this pull request Oct 28, 2021
@Lincong @lmr3796
[LI-HOTFIX] CI: Migrate CI build to Github Actions
ed9a488 
This commit is a squash of:
- 97f6a93 [LI-HOTFIX] Add a Github Actions workflow to trigger build and test upon PR and push (#106)
- bb6cab9 [LI-HOTFIX] Add a Github Actions workflow to trigger build and run all tests upon a tag creation/push (#107)
- 4ac92ac [LI-HOTFIX] Enable the Github Actions workflow to upload the built archive and disable all Travis actions (#108)
- 883ece3 [LI-HOTFIX] Updating description of the CI flow (#114)
- 77cad71 [LI-HOTFIX] Add rat to CI build to make it consistent with PR (#173)
- 2af73a1 [LI-HOTFIX] CI: Split test builds to multiple jobs
- 22517e6 [LI-HOTFIX] CI: Enable spotbugs on build (#195)

And partially picked up the rat set up from
- 66596f0 [LI-HOTFIX] Adding licence and rat check (#159)

TICKET = N/A
LI_DESCRIPTION = LIKAFKA-34202
EXIT_CRITERIA = When migrating off Github Actions for CI
lmr3796 pushed a commit to lmr3796/kafka that referenced this pull request Nov 19, 2021
@Lincong @lmr3796
[LI-HOTFIX] CI: Migrate CI build to Github Actions
bbf8da5 
This commit is a squash of:
- 97f6a93 [LI-HOTFIX] Add a Github Actions workflow to trigger build and test upon PR and push (linkedin#106)
- bb6cab9 [LI-HOTFIX] Add a Github Actions workflow to trigger build and run all tests upon a tag creation/push (linkedin#107)
- 4ac92ac [LI-HOTFIX] Enable the Github Actions workflow to upload the built archive and disable all Travis actions (linkedin#108)
- e3ca505 [LI-HOTFIX] Add note on LinkedIn Kafka Branch to README
- 883ece3 [LI-HOTFIX] Updating description of the CI flow (linkedin#114)
- 77cad71 [LI-HOTFIX] Add rat to CI build to make it consistent with PR (linkedin#173)
- 2af73a1 [LI-HOTFIX] CI: Split test builds to multiple jobs
- 22517e6 [LI-HOTFIX] CI: Enable spotbugs on build (linkedin#195)

And partially picked up the rat set up from
- 66596f0 [LI-HOTFIX] Adding licence and rat check (linkedin#159)

TICKET = N/A
LI_DESCRIPTION = LIKAFKA-34202
EXIT_CRITERIA = When migrating off Github Actions for CI
lmr3796 pushed a commit that referenced this pull request Jan 1, 2022
@Lincong @lmr3796
[LI-HOTFIX] CI: Migrate CI build to Github Actions
a77d9e7 
This commit is a squash of:
- 97f6a93 [LI-HOTFIX] Add a Github Actions workflow to trigger build and test upon PR and push (#106)
- bb6cab9 [LI-HOTFIX] Add a Github Actions workflow to trigger build and run all tests upon a tag creation/push (#107)
- 4ac92ac [LI-HOTFIX] Enable the Github Actions workflow to upload the built archive and disable all Travis actions (#108)
- e3ca505 [LI-HOTFIX] Add note on LinkedIn Kafka Branch to README
- 883ece3 [LI-HOTFIX] Updating description of the CI flow (#114)
- 77cad71 [LI-HOTFIX] Add rat to CI build to make it consistent with PR (#173)
- 2af73a1 [LI-HOTFIX] CI: Split test builds to multiple jobs
- 22517e6 [LI-HOTFIX] CI: Enable spotbugs on build (#195)

And partially picked up the rat set up from
- 66596f0 [LI-HOTFIX] Adding licence and rat check (#159)

TICKET = N/A
LI_DESCRIPTION = LIKAFKA-34202
EXIT_CRITERIA = When migrating off Github Actions for CI
lmr3796 pushed a commit to lmr3796/kafka that referenced this pull request Jun 2, 2022
@Lincong @lmr3796
[LI-HOTFIX] CI: Migrate CI build to Github Actions
76b2ef9 
This commit is a squash of:
- 97f6a93 [LI-HOTFIX] Add a Github Actions workflow to trigger build and test upon PR and push (linkedin#106)
- bb6cab9 [LI-HOTFIX] Add a Github Actions workflow to trigger build and run all tests upon a tag creation/push (linkedin#107)
- 4ac92ac [LI-HOTFIX] Enable the Github Actions workflow to upload the built archive and disable all Travis actions (linkedin#108)
- e3ca505 [LI-HOTFIX] Add note on LinkedIn Kafka Branch to README
- 883ece3 [LI-HOTFIX] Updating description of the CI flow (linkedin#114)
- 77cad71 [LI-HOTFIX] Add rat to CI build to make it consistent with PR (linkedin#173)
- 2af73a1 [LI-HOTFIX] CI: Split test builds to multiple jobs
- 22517e6 [LI-HOTFIX] CI: Enable spotbugs on build (linkedin#195)

And partially picked up the rat set up from
- 66596f0 [LI-HOTFIX] Adding licence and rat check (linkedin#159)

TICKET = N/A
LI_DESCRIPTION = LIKAFKA-34202
EXIT_CRITERIA = When migrating off Github Actions for CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gitlw gitlw gitlw approved these changes
@yifangl yifangl Awaiting requested review from yifangl

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Lincong @gitlw