Skip to content

Conversation

@maluchari
Copy link
Collaborator

In the cleans up path lockId is not returned in code for cleanup and hence becomes a no-op during unlock.

@github-actions github-actions bot added the HIVE label Feb 4, 2022
@rzhang10
Copy link
Member

rzhang10 commented Feb 7, 2022

I have several points here:

  • these 2 branches are when the lock state is waiting or is not required, this means other processes/threads must have hold the lock. So it's actually inaccurate if we try to release the locks on their behalf?
  • it seems our hive doesn't enable concurrency currently, so seems this entire locking/unlocking on HMS might just have no effect to begin with. I doubt the original issue is really caused by this.

@maluchari
Copy link
Collaborator Author

Closing this as this seems to have been fixed upstream in this PR

@maluchari maluchari closed this Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants