Move to Avro 1.10.2 #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenodaguirguis
force-pushed
the
master
branch
4 times, most recently
from
ac3d485 to
4c7c31c
Compare
Author
|
@rzhang10 FYI |
wmoustafa
reviewed
Sep 16, 2021
hive-metastore/src/main/java/org/apache/iceberg/hive/legacy/LegacyHiveTableUtils.java
Outdated
Show resolved
Hide resolved
shenodaguirguis
force-pushed
the
master
branch
from
4c7c31c to
befeb29
Compare
Member
|
I see a comment in upstream #1648 apache/iceberg#1648 (comment) , should we also consider using 1.10.1 instead of 1.10.2 ? |
Author
@rzhang10 the avro parser feature to disable defaults validation exists starting avro 1.10.2, and this PR is mainly to use it. And yes I saw that comment and spent significant time to fix the jackson issue (the changes in build.gradle, specifically |
rzhang10
reviewed
Sep 17, 2021
hive-metastore/src/main/java/org/apache/iceberg/hive/legacy/LegacyHiveTableUtils.java
Show resolved
Hide resolved
wmoustafa
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iceberg currently uses Avro 1.9, which throws an Exception for Malformed/wrong-typed default values. Now that we added support for default-values in Iceberg, for ORC and AVRO formats, this might cause trouble with ecosystems that uses AVRO 1.7, which only warns about malformed/wrong-typed defaults values and silently sets no-default-value. Avro 1.10.2 provides an API that gives the caller the option to skip validating the default value.
Note: it will still fail at the Iceberg schema level, given wronged-typed default value, which will give the caller the meaningful error to correct their schema.